Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: extensions/renderer/resources/send_request.js

Issue 2794043002: [Extensions Bindings] Move safeCallbackApply to exception handler (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/send_request.js
diff --git a/extensions/renderer/resources/send_request.js b/extensions/renderer/resources/send_request.js
index d2b02b89f5b0deef6929fdfdca1730ce8e557a8a..bb7695047296ad7e2fcbafa6fa45857a587aadb5 100644
--- a/extensions/renderer/resources/send_request.js
+++ b/extensions/renderer/resources/send_request.js
@@ -8,6 +8,8 @@ var logging = requireNative('logging');
var natives = requireNative('sendRequest');
var validate = require('schemaUtils').validate;
+var safeCallbackApply = exceptionHandler.safeCallbackApply;
+
// All outstanding requests from sendRequest().
var requests = { __proto__: null };
@@ -15,15 +17,6 @@ var requests = { __proto__: null };
// bindings and ExtensionFunctions (via sendRequest).
var calledSendRequest = false;
-// Runs a user-supplied callback safely.
-function safeCallbackApply(name, request, callback, args) {
- try {
- $Function.apply(callback, request, args);
- } catch (e) {
- exceptionHandler.handle('Error in response to ' + name, e, request.stack);
- }
-}
-
// Callback handling.
function handleResponse(requestId, name, success, responseList, error) {
// The chrome objects we will set lastError on. Really we should only be
@@ -143,7 +136,6 @@ function clearCalledSendRequest() {
exports.$set('sendRequest', sendRequest);
exports.$set('getCalledSendRequest', getCalledSendRequest);
exports.$set('clearCalledSendRequest', clearCalledSendRequest);
-exports.$set('safeCallbackApply', safeCallbackApply);
// Called by C++.
exports.$set('handleResponse', handleResponse);
« no previous file with comments | « extensions/renderer/resources/binding.js ('k') | extensions/renderer/resources/uncaught_exception_handler.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698