Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2793753002: [SPv2] Switch the application order between effects and CSS clip (Closed)

Created:
3 years, 8 months ago by trchen
Modified:
3 years, 8 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPv2] Switch the application order between effects and CSS clip According to SVG spec, clipping, masking, and opacity applies after filter. The CSS version follows the same order. This is also what SPv1 and other vendors implemented. BUG=707455 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2793753002 Cr-Commit-Position: refs/heads/master@{#461541} Committed: https://chromium.googlesource.com/chromium/src/+/6b2de0f362490dc4823e64976d9682c37a62c64d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/clip/css-clip-filter-order.html View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/clip/css-clip-filter-order-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
trchen
3 years, 8 months ago (2017-04-01 01:00:22 UTC) #3
chrishtr
lgtm
3 years, 8 months ago (2017-04-01 04:04:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793753002/1
3 years, 8 months ago (2017-04-03 19:08:42 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 21:15:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b2de0f362490dc4823e64976d96...

Powered by Google App Engine
This is Rietveld 408576698