Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2793753002: [SPv2] Switch the application order between effects and CSS clip (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/clip/css-clip-filter-order-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/paint/PaintPropertyTreeBuilder.h" 5 #include "core/paint/PaintPropertyTreeBuilder.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include "core/dom/DOMNodeIds.h" 8 #include "core/dom/DOMNodeIds.h"
9 #include "core/frame/FrameView.h" 9 #include "core/frame/FrameView.h"
10 #include "core/frame/LocalFrame.h" 10 #include "core/frame/LocalFrame.h"
(...skipping 1090 matching lines...) Expand 10 before | Expand all | Expand 10 after
1101 // This is not in FindObjectPropertiesNeedingUpdateScope because paint offset 1101 // This is not in FindObjectPropertiesNeedingUpdateScope because paint offset
1102 // can change without needsPaintPropertyUpdate. 1102 // can change without needsPaintPropertyUpdate.
1103 updateForObjectLocationAndSize(object, context); 1103 updateForObjectLocationAndSize(object, context);
1104 1104
1105 #if DCHECK_IS_ON() 1105 #if DCHECK_IS_ON()
1106 FindObjectPropertiesNeedingUpdateScope checkNeedsUpdateScope(object, context); 1106 FindObjectPropertiesNeedingUpdateScope checkNeedsUpdateScope(object, context);
1107 #endif 1107 #endif
1108 1108
1109 if (object.isBoxModelObject() || object.isSVG()) { 1109 if (object.isBoxModelObject() || object.isSVG()) {
1110 updateTransform(object, context); 1110 updateTransform(object, context);
1111 updateCssClip(object, context);
1111 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 1112 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
1112 updateEffect(object, context); 1113 updateEffect(object, context);
1113 updateFilter(object, context); 1114 updateFilter(object, context);
1114 } 1115 }
1115 updateCssClip(object, context);
1116 updateLocalBorderBoxContext(object, context); 1116 updateLocalBorderBoxContext(object, context);
1117 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) 1117 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
1118 updateScrollbarPaintOffset(object, context); 1118 updateScrollbarPaintOffset(object, context);
1119 } 1119 }
1120 } 1120 }
1121 1121
1122 void PaintPropertyTreeBuilder::updatePropertiesForChildren( 1122 void PaintPropertyTreeBuilder::updatePropertiesForChildren(
1123 const LayoutObject& object, 1123 const LayoutObject& object,
1124 PaintPropertyTreeBuilderContext& context) { 1124 PaintPropertyTreeBuilderContext& context) {
1125 #if DCHECK_IS_ON() 1125 #if DCHECK_IS_ON()
1126 FindObjectPropertiesNeedingUpdateScope checkNeedsUpdateScope(object, context); 1126 FindObjectPropertiesNeedingUpdateScope checkNeedsUpdateScope(object, context);
1127 #endif 1127 #endif
1128 1128
1129 if (!object.isBoxModelObject() && !object.isSVG()) 1129 if (!object.isBoxModelObject() && !object.isSVG())
1130 return; 1130 return;
1131 1131
1132 updateOverflowClip(object, context); 1132 updateOverflowClip(object, context);
1133 updatePerspective(object, context); 1133 updatePerspective(object, context);
1134 updateSvgLocalToBorderBoxTransform(object, context); 1134 updateSvgLocalToBorderBoxTransform(object, context);
1135 updateScrollAndScrollTranslation(object, context); 1135 updateScrollAndScrollTranslation(object, context);
1136 updateOutOfFlowContext(object, context); 1136 updateOutOfFlowContext(object, context);
1137 1137
1138 context.forceSubtreeUpdate |= object.subtreeNeedsPaintPropertyUpdate(); 1138 context.forceSubtreeUpdate |= object.subtreeNeedsPaintPropertyUpdate();
1139 } 1139 }
1140 1140
1141 } // namespace blink 1141 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/clip/css-clip-filter-order-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698