AudioWorklet prototype

[hongchan, 2017-05-15 21:42:54]

Description was changed from

==========
Implement AudioWorkletNode interface

This CL is to add AudioWorkletNode constructor and AudioWorklet
reference to BaseAudioContext.

BUG=691782
TEST=
LayoutTests/webaudio/audioworklet/audioworkletnode-basic.html
==========

to

==========
Implement AudioWorkletNode interface

This CL is to add AudioWorkletNode constructor and AudioWorklet
reference to BaseAudioContext.

BUG=691782
TEST=
LayoutTests/webaudio/audioworklet/audioworkletnode-basic.html
LayoutTests/webaudio/audioworklet/audioworklet-import.html
==========

[hongchan, 2017-05-31 17:45:51]

Patchset #5 (id:80001) has been deleted

[nhiroki, 2017-06-07 14:43:51]

nhiroki@chromium.org changed reviewers:
+ nhiroki@chromium.org

[nhiroki, 2017-06-07 14:43:52]

https://codereview.chromium.org/2793593002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.cpp
(right):

https://codereview.chromium.org/2793593002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.cpp:27:
class AudioWorkletMessagingProxy::LoaderClient final
We could factor out this class to share this with ThreadedMessagingProxyBase.

https://codereview.chromium.org/2793593002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.cpp:117:
GetWorkerInspectorProxy()->WorkerThreadCreated(document, GetWorkerThread(),
By the recent change, WorkerInspectorProxy::WorkerThreadCreated() is now called
in ThreadedMessagingProxyBase::InitializeWorkerThread(), so you don't have to
call it here.

https://codereview.chromium.org/2793593002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.h
(right):

https://codereview.chromium.org/2793593002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.h:71:
std::unique_ptr<AudioWorkletObjectProxy> worklet_object_proxy_;
If having the AudioWorkletObjectProxy is the only difference from
ThreadedWorkletMessagingProxy, how about adding a virtual function to create the
object proxy in ThreadedWorkletMessagingProxy, making AudioWorkletMessagingProxy
override it and calling it in the ctor of ThreadedWorkletMessagingProxy like
this?

ThreadedWorkletMessagingProxy::ThreadedWorkletMessagingProxy(
    ExecutionContext* execution_context,
    WorkerClients* worker_clients)
    : ThreadedMessagingProxyBase(execution_context, worker_clients),
      weak_ptr_factory_(this) {
//  worklet_object_proxy_ = ThreadedWorkletObjectProxy::Create(
//      weak_ptr_factory_.CreateWeakPtr(), GetParentFrameTaskRunners());

  // CreateObjectProxy() is a virtual function and overridden
  // by AudioWorkletMessagingProxy.
  worklet_object_proxy_ = CreateObjectProxy(
      weak_ptr_factory_CreateWeakPtr(), GetParentFrameTaskRunners());
}

class AudioWorkletMessagingProxy : public ThreadedMessagingProxyBase {
 private:
   std::unique_ptr<WorkletObjectProxy> CreateObjectProxy(...) override {
     return WTF::MakeUnique<AudioWorkletObjectProxy>(...);
   }
}

https://codereview.chromium.org/2793593002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.h (right):

https://codereview.chromium.org/2793593002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.h:22: static
PassRefPtr<AudioWorkletHandler> Create(AudioNode&,
PassRefPtr is deprecated. Can you use RefPtr?

[hongchan, 2017-07-19 20:43:56]

Description was changed from

==========
Implement AudioWorkletNode interface

This CL is to add AudioWorkletNode constructor and AudioWorklet
reference to BaseAudioContext.

BUG=691782
TEST=
LayoutTests/webaudio/audioworklet/audioworkletnode-basic.html
LayoutTests/webaudio/audioworklet/audioworklet-import.html
==========

to

==========

==========

[hongchan, 2017-07-19 20:43:57]

hongchan@chromium.org changed reviewers:
- nhiroki@chromium.org