Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2793573002: [Payments] Use <meta-data> tag instead of intent filter data to detect supported payment methods. (Closed)

Created:
3 years, 8 months ago by gogerald1
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use <meta-data> tag instead of intent filter data to detect supported payment methods. Design doc: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE To test: 1) Install BobPayWithMetaData.apk from https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNSllxOWtTU0U0TDQ/view?usp=sharing 2) Enable chrome://flags/#android-payment-apps. 3) Navigate to https://rsolomakhin.github.io/pr/bob/. 4) Click "Buy" button on the webpage. BUG=707246 Review-Url: https://codereview.chromium.org/2793573002 Cr-Commit-Position: refs/heads/master@{#461274} Committed: https://chromium.googlesource.com/chromium/src/+/7bb0a7ba88c589910ed35f74f7892ef93fbd0eda

Patch Set 1 #

Total comments: 17

Patch Set 2 : address comments #

Patch Set 3 : remove unecessary check #

Patch Set 4 : move <meta-data> to pay activity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -64 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java View 1 2 3 5 chunks +100 lines, -29 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PackageManagerDelegate.java View 1 2 3 4 chunks +40 lines, -0 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinderTest.java View 1 2 3 6 chunks +130 lines, -35 lines 0 comments Download

Messages

Total messages: 43 (31 generated)
gogerald1
Hi rouslan@, ptal,
3 years, 8 months ago (2017-03-31 15:08:44 UTC) #14
please use gerrit instead
https://codereview.chromium.org/2793573002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java File chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java (right): https://codereview.chromium.org/2793573002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java#newcode183 chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java:183: if (!mPaymentMethods.isEmpty()) { This check seems redundant now. Let's ...
3 years, 8 months ago (2017-03-31 15:47:08 UTC) #17
gogerald1
Thanks, please take another look, https://codereview.chromium.org/2793573002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java File chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java (right): https://codereview.chromium.org/2793573002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java#newcode183 chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java:183: if (!mPaymentMethods.isEmpty()) { On ...
3 years, 8 months ago (2017-03-31 16:18:44 UTC) #20
please use gerrit instead
LGTM % comment. Please remove the redundant mPaymentMethods.isEmpty() check. https://codereview.chromium.org/2793573002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java File chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java (right): https://codereview.chromium.org/2793573002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java#newcode183 chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java:183: ...
3 years, 8 months ago (2017-03-31 16:26:30 UTC) #21
gogerald1
https://codereview.chromium.org/2793573002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java File chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java (right): https://codereview.chromium.org/2793573002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java#newcode183 chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java:183: if (!mPaymentMethods.isEmpty()) { On 2017/03/31 16:26:30, ಠ_ಠ wrote: > ...
3 years, 8 months ago (2017-03-31 16:28:54 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793573002/100001
3 years, 8 months ago (2017-03-31 16:35:03 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/262346)
3 years, 8 months ago (2017-03-31 17:23:58 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793573002/100001
3 years, 8 months ago (2017-03-31 17:35:49 UTC) #29
gogerald1
Hi rouslan@, please take another look, update the CL to match the spec,
3 years, 8 months ago (2017-03-31 21:56:45 UTC) #34
please use gerrit instead
lgtm
3 years, 8 months ago (2017-03-31 22:19:06 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793573002/140001
3 years, 8 months ago (2017-03-31 23:36:56 UTC) #40
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 23:45:10 UTC) #43
Message was sent while issue was closed.
Committed patchset #4 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/7bb0a7ba88c589910ed35f74f789...

Powered by Google App Engine
This is Rietveld 408576698