[Payments] Use <meta-data> tag instead of intent filter data to detect supported payment methods.

chrome/android/java/src/org/chromium/chrome/browser/payments/PackageManagerDelegate.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.payments;
 
 import android.content.Intent;
+import android.content.pm.ApplicationInfo;
 import android.content.pm.PackageInfo;
 import android.content.pm.PackageManager;
 import android.content.pm.PackageManager.NameNotFoundException;
 import android.content.pm.ResolveInfo;
+import android.content.res.Resources;
 import android.graphics.drawable.Drawable;
 import android.os.StrictMode;
 import android.os.StrictMode.ThreadPolicy;
 
 import org.chromium.base.ContextUtils;
 
 import java.util.List;
 
+import javax.annotation.Nullable;
+
 /** Abstraction of Android's package manager to enable unit testing. */
 public class PackageManagerDelegate {
     /**
      * Retrieves package information of an installed application.
      *
      * @param packageName The package name of an installed application.
      * @return The package information of the installed application.
      */
     public PackageInfo getPackageInfoWithSignatures(String packageName) {
         try {
@@ skipping 59 matching lines @@
     }
 
     /**
      * Retrieves the icon of the app.
      * @param resolveInfo The identifying information for an app.
      * @return The icon for this app.
      */
     public Drawable getAppIcon(ResolveInfo resolveInfo) {
         return resolveInfo.loadIcon(ContextUtils.getApplicationContext().getPackageManager());
     }
+
+    /**
+     * Gets the given string array meta data from the given app.
+     *
+     * @param packageName  The package name of the app containing the meta data.
+     * @param metaDataName The meta data name of the string array.
+     * @return The string array or null.
+     */
+    @Nullable
+    public String[] getStringArrayMetaData(String packageName, String metaDataName) {
+        try {
+            PackageManager packageManager =
+                    ContextUtils.getApplicationContext().getPackageManager();
+            ApplicationInfo appInfo =
+                    packageManager.getApplicationInfo(packageName, PackageManager.GET_META_DATA);
+            if (appInfo.metaData == null) return null;
+
+            int resId = appInfo.metaData.getInt(metaDataName);
+            Resources resources = packageManager.getResourcesForApplication(appInfo);
+            return resources.getStringArray(resId);
+        } catch (NameNotFoundException e) {

[please use gerrit instead, 2017/03/31 15:47:08]

Let's wrap in try-catch only the function that throws this exception:
getApplicationInfo().

[gogerald1, 2017/03/31 16:18:44]

Done. getResourcesForApplication might also through that exception

+            return null;
+        }
+    }
+
+    /**
+     * Gets the given string meta data from the given app.
+     *
+     * @param packageName  The package name of the app containing the meta data.
+     * @param metaDataName The meta data name of the string.
+     * @return The string or null.
+     */
+    @Nullable
+    public String getStringMetaData(String packageName, String metaDataName) {
+        try {
+            PackageManager packageManager =
+                    ContextUtils.getApplicationContext().getPackageManager();
+            ApplicationInfo appInfo =
+                    packageManager.getApplicationInfo(packageName, PackageManager.GET_META_DATA);
+            if (appInfo.metaData == null) return null;
+
+            return appInfo.metaData.getString(metaDataName);
+        } catch (NameNotFoundException e) {

[please use gerrit instead, 2017/03/31 15:47:08]

Ditto.

[gogerald1, 2017/03/31 16:18:44]

Done. Ditto

+            return null;
+        }
+    }
 }