Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2793493003: Do not rotate frames from external cameras (Closed)

Created:
3 years, 8 months ago by henryhsu
Modified:
3 years, 8 months ago
Reviewers:
Pawel Osciak
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Do not rotate frames from external cameras When the frames are from external cameras, do not rotate them even if the device itself is rotated. This way, the user can have a fixed external camera no matter how the CrOS device is rotated. BUG=701028 TEST=Verified on minnie with a fixed external camera that in tent mode, 90-degree-rotated and 270-degree-rotated mode, the chrome camera app still shows correct preview. TBR=posciak@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2762603002 Cr-Commit-Position: refs/heads/master@{#459048} (cherry picked from commit f1ce4f776d2e9018a8d7dbe381658e51c1aa5db8) Review-Url: https://codereview.chromium.org/2793493003 Cr-Commit-Position: refs/branch-heads/3029@{#507} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/4374383e095dd01918de6287d46a71f0b4f999c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M media/capture/video/linux/video_capture_device_chromeos.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.cc View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793493003/1
3 years, 8 months ago (2017-03-31 04:19:03 UTC) #2
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 04:26:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4374383e095dd01918de6287d46a...

Powered by Google App Engine
This is Rietveld 408576698