Do not rotate frames from external cameras

Do not rotate frames from external cameras

When the frames are from external cameras, do not rotate them even if
the device itself is rotated. This way, the user can have a fixed
external camera no matter how the CrOS device is rotated.

BUG=701028
TEST=Verified on minnie with a fixed external camera that in tent
mode, 90-degree-rotated and 270-degree-rotated mode, the chrome camera
app still shows correct preview.

Review-Url: https://codereview.chromium.org/2762603002
Cr-Commit-Position: refs/heads/master@{#459048}
Committed: https://chromium.googlesource.com/chromium/src/+/f1ce4f776d2e9018a8d7dbe381658e51c1aa5db8

[shenghao, 2017-03-20 08:15:30]

Description was changed from

==========
Do not rotate frames from external cameras

When the frames are from external cameras, do not rotate them even if
the device itself is rotated. This way, the user can have a fixed
external camera no matter how the CrOS device is rotated.

BUG=701028
TEST=Verified on minnie with a fixed external camera that in tent
mode, 90-degree-rotated and 270-degree-rotated mode, the chrome camera
app still shows correct preview.
==========

to

==========
Do not rotate frames from external cameras

When the frames are from external cameras, do not rotate them even if
the device itself is rotated. This way, the user can have a fixed
external camera no matter how the CrOS device is rotated.

BUG=701028
TEST=Verified on minnie with a fixed external camera that in tent
mode, 90-degree-rotated and 270-degree-rotated mode, the chrome camera
app still shows correct preview.
==========

[shenghao, 2017-03-20 08:15:30]

shenghao@chromium.org changed reviewers:
+ posciak@chromium.org, wuchengli@chromium.org

[chfremer, 2017-03-20 16:32:45]

chfremer@chromium.org changed reviewers:
+ chfremer@chromium.org

[chfremer, 2017-03-20 16:32:47]

https://codereview.chromium.org/2762603002/diff/1/media/capture/video/linux/v...
File media/capture/video/linux/video_capture_device_chromeos.cc (right):

https://codereview.chromium.org/2762603002/diff/1/media/capture/video/linux/v...
media/capture/video/linux/video_capture_device_chromeos.cc:158: rotation = 0;
As a drive-by nit, I wonder if we could make things more obvious by introducing
a member |rotates_with_device_| and setting it to false for external cameras.
Otherwise, we run the risk that future developers may not be aware that setting
a MEDIA_VIDEO_FACING_NONE implies no rotation with the device.

[shenghao, 2017-03-21 06:06:23]

The CQ bit was checked by shenghao@chromium.org to run a CQ dry run

[shenghao, 2017-03-21 06:06:32]

https://codereview.chromium.org/2762603002/diff/1/media/capture/video/linux/v...
File media/capture/video/linux/video_capture_device_chromeos.cc (right):

https://codereview.chromium.org/2762603002/diff/1/media/capture/video/linux/v...
media/capture/video/linux/video_capture_device_chromeos.cc:158: rotation = 0;
On 2017/03/20 16:32:47, chfremer wrote:
> As a drive-by nit, I wonder if we could make things more obvious by
introducing
> a member |rotates_with_device_| and setting it to false for external cameras.
> Otherwise, we run the risk that future developers may not be aware that
setting
> a MEDIA_VIDEO_FACING_NONE implies no rotation with the device.

Done.

[commit-bot: I haz the power, 2017-03-21 06:06:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 07:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 07:06:49]

Dry run: This issue passed the CQ dry run.

[Pawel Osciak, 2017-03-23 08:52:51]

lgtm

[shenghao, 2017-03-23 10:35:12]

The CQ bit was checked by shenghao@chromium.org

[commit-bot: I haz the power, 2017-03-23 10:35:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 11:37:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490265312661530,
"parent_rev": "a6be2b34861576aca5cc181caf86d494d933f48c", "commit_rev":
"f1ce4f776d2e9018a8d7dbe381658e51c1aa5db8"}

[commit-bot: I haz the power, 2017-03-23 11:38:05]

Description was changed from

==========
Do not rotate frames from external cameras

When the frames are from external cameras, do not rotate them even if
the device itself is rotated. This way, the user can have a fixed
external camera no matter how the CrOS device is rotated.

BUG=701028
TEST=Verified on minnie with a fixed external camera that in tent
mode, 90-degree-rotated and 270-degree-rotated mode, the chrome camera
app still shows correct preview.
==========

to

==========
Do not rotate frames from external cameras

When the frames are from external cameras, do not rotate them even if
the device itself is rotated. This way, the user can have a fixed
external camera no matter how the CrOS device is rotated.

BUG=701028
TEST=Verified on minnie with a fixed external camera that in tent
mode, 90-degree-rotated and 270-degree-rotated mode, the chrome camera
app still shows correct preview.

Review-Url: https://codereview.chromium.org/2762603002
Cr-Commit-Position: refs/heads/master@{#459048}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1ce4f776d2e9018a8d7dbe38165...
==========

[commit-bot: I haz the power, 2017-03-23 11:38:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f1ce4f776d2e9018a8d7dbe38165...