Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2793423002: [instrumentation] Move "include" section from PIDL to JSON5 config (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[instrumentation] Move "include" section from PIDL to JSON5 config BUG=695625 Review-Url: https://codereview.chromium.org/2793423002 Cr-Commit-Position: refs/heads/master@{#462207} Committed: https://chromium.googlesource.com/chromium/src/+/ebef20203ecdd7fb17431298e175bc15546dc3ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -28 lines) Patch
M third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py View 4 chunks +3 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/probe/CoreProbes.json5 View 2 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/probe/CoreProbes.pidl View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/probe/PlatformProbes.json5 View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
alph
3 years, 8 months ago (2017-04-04 19:03:54 UTC) #2
pfeldman
lgtm
3 years, 8 months ago (2017-04-04 20:28:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793423002/1
3 years, 8 months ago (2017-04-05 17:05:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/422610)
3 years, 8 months ago (2017-04-05 18:26:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793423002/1
3 years, 8 months ago (2017-04-05 19:13:56 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 20:44:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ebef20203ecdd7fb17431298e175...

Powered by Google App Engine
This is Rietveld 408576698