[instrumentation] Move "include" section from PIDL to JSON5 config

third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import ast
 import optparse
 import os.path
 import re
 import sys
 
@@ skipping 30 matching lines @@
 
 def to_singular(text):
     return text[:-1] if text[-1] == "s" else text
 
 
 def to_lower_case(name):
     return name[:1].lower() + name[1:]
 
 
 def agent_config(agent_name, field):
-    observers = config["observers"]
-    if agent_name not in observers:
-        return None
-    return observers[agent_name][field] if field in observers[agent_name] else None
+    return config["observers"].get(agent_name, {}).get(field)
 
 
 def agent_name_to_class(agent_name):
     return agent_config(agent_name, "class") or "Inspector%sAgent" % agent_name
 
 
 def agent_name_to_include(agent_name):
-    include_path = agent_config(agent_name, "include") or config["settings"]["default_include"]
+    include_path = agent_config(agent_name, "include_path") or config["settings"]["include_path"]
     return os.path.join(include_path, agent_name_to_class(agent_name) + ".h")
 
 
 def initialize_jinja_env(cache_dir):
     jinja_env = jinja2.Environment(
         loader=jinja2.FileSystemLoader(os.path.join(module_path, "templates")),
         # Bytecode cache is not concurrency-safe unless pre-cached:
         # if pre-cached this is read-only, but writing creates a race condition.
         bytecode_cache=jinja2.FileSystemBytecodeCache(cache_dir),
         keep_trailing_newline=True,  # newline-terminate generated files
@@ skipping 23 matching lines @@
     model = []
     while len(source):
         match, source = match_and_consume(r"interface\s(\w*)\s?\{([^\{]*)\}", source)
         if not match:
             sys.stderr.write("Cannot parse %s\n" % source[:100])
             sys.exit(1)
         model.append(File(match.group(1), match.group(2)))
     return model
 
 
-def include_probes_header():
-    return "#include \"%s\"" % config["settings"]["probes_header"]
-
-
 class File(object):
     def __init__(self, name, source):
         self.name = name
         self.header_name = self.name + "Inl"
-        self.includes = [include_probes_header()]
         self.forward_declarations = []
         self.declarations = []
         for line in map(str.strip, source.split("\n")):
             line = re.sub(r"\s{2,}", " ", line).strip()  # Collapse whitespace
             if len(line) == 0:
                 continue
-            elif line.startswith("#include"):
-                self.includes.append(line)
             elif line.startswith("class ") or line.startswith("struct "):
                 self.forward_declarations.append(line)
             else:
                 self.declarations.append(Method(line))
-        self.includes.sort()
         self.forward_declarations.sort()
 
 
 class Method(object):
     def __init__(self, source):
         match = re.match(r"(?:(\w+\*?)\s+)?(\w+)\s*\((.*)\)\s*;", source)
         if not match:
             sys.stderr.write("Cannot parse %s\n" % source)
             sys.exit(1)
 
@@ skipping 66 matching lines @@
     all_observers = set()
     observers_by_probe = {}
     unused_probes = set(all_pidl_probes)
     for observer_name in config["observers"]:
         all_observers.add(observer_name)
         observer = config["observers"][observer_name]
         for probe in observer["probes"]:
             unused_probes.discard(probe)
             if probe not in all_pidl_probes:
                 raise Exception('Probe %s is not declared in PIDL file' % probe)
-            if probe not in observers_by_probe:
-                observers_by_probe[probe] = set()
-            observers_by_probe[probe].add(observer_name)
+            observers_by_probe.setdefault(probe, set()).add(observer_name)
     if unused_probes:
         raise Exception("Unused probes: %s" % unused_probes)
 
     for f in files:
         for probe in f.declarations:
             probe.agents = observers_by_probe[probe.name]
     return all_observers
 
 
 cmdline_parser = optparse.OptionParser()
@@ skipping 43 matching lines @@
 sink_h_file = open(output_dirpath + "/" + to_singular(base_name) + "Sink.h", "w")
 sink_h_file.write(sink_h_template.render(template_context))
 sink_h_file.close()
 
 for f in files:
     template_context["file"] = f
     h_template = jinja_env.get_template("/InstrumentingProbesInl.h.tmpl")
     h_file = open(output_dirpath + "/" + f.header_name + ".h", "w")
     h_file.write(h_template.render(template_context))
     h_file.close()