Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp

Issue 2793273002: Use internal hooks for notifying fullscreen changes to media controls (Closed)
Patch Set: update more tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp
index c1505c696312bbcb4125a6083efbe17586fa8b19..72b702f5daa8bed84e90e9110ab7ef19b2e8ac4c 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp
@@ -81,7 +81,6 @@ TEST_F(HTMLMediaElementEventListenersTest, RemovingFromDocumentCollectsAll) {
EXPECT_NE(video(), nullptr);
EXPECT_TRUE(video()->hasEventListeners());
EXPECT_NE(controls(), nullptr);
- EXPECT_TRUE(document().hasEventListeners());
WeakPersistent<HTMLVideoElement> weakPersistentVideo = video();
WeakPersistent<MediaControls> weakPersistentControls = controls();
@@ -89,9 +88,6 @@ TEST_F(HTMLMediaElementEventListenersTest, RemovingFromDocumentCollectsAll) {
Persistent<HTMLVideoElement> persistentVideo = video();
document().body()->setInnerHTML("");
- // When removed from the document, the event listeners should have been
- // dropped.
- EXPECT_FALSE(document().hasEventListeners());
// The video element should still have some event listeners.
EXPECT_TRUE(persistentVideo->hasEventListeners());
}
@@ -110,7 +106,6 @@ TEST_F(HTMLMediaElementEventListenersTest,
EXPECT_NE(video(), nullptr);
EXPECT_TRUE(video()->hasEventListeners());
EXPECT_NE(controls(), nullptr);
- EXPECT_TRUE(document().hasEventListeners());
// This should be a no-op. We keep a reference on the VideoElement to avoid an
// unexpected GC.
@@ -120,7 +115,6 @@ TEST_F(HTMLMediaElementEventListenersTest,
document().body()->appendChild(videoHolder.get());
}
- EXPECT_TRUE(document().hasEventListeners());
EXPECT_TRUE(video()->hasEventListeners());
ThreadState::current()->collectAllGarbage();

Powered by Google App Engine
This is Rietveld 408576698