Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2793273002: Use internal hooks for notifying fullscreen changes to media controls (Closed)
Patch Set: update more tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 920ab117c5f36287cde9d779bafc3f069e51be63..5748124b77e67bd9dee314115827c66747812836 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -3519,6 +3519,8 @@ void HTMLMediaElement::didEnterFullscreen() {
// FIXME: There is no embedder-side handling in layout test mode.
if (webMediaPlayer() && !LayoutTestSupport::isRunningLayoutTest())
webMediaPlayer()->enteredFullscreen();
+ if (mediaControls())
+ mediaControls()->didEnterFullscreen();
// Cache this in case the player is destroyed before leaving fullscreen.
m_inOverlayFullscreenVideo = usesOverlayFullscreenVideo();
if (m_inOverlayFullscreenVideo)
@@ -3531,6 +3533,8 @@ void HTMLMediaElement::didExitFullscreen() {
if (webMediaPlayer())
webMediaPlayer()->exitedFullscreen();
+ if (mediaControls())
+ mediaControls()->didExitFullscreen();
if (m_inOverlayFullscreenVideo)
document().layoutViewItem().compositor()->setNeedsCompositingUpdate(
CompositingUpdateRebuildTree);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698