third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp - Issue 2793273002: Use internal hooks for notifying fullscreen changes to media controls

Unified Diff: third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp

Issue 2793273002: Use internal hooks for notifying fullscreen changes to media controls (Closed)

Patch Set: update more tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp ('k') | third_party/WebKit/Source/core/html/shadow/MediaControls.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp

diff --git a/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp b/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp

index 9a1eea922fbec95f4bb1a5e57d2f9af583d28eb4..be232ddd8c079d7831ab6c9865450b5277ff1c09 100644

--- a/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp

+++ b/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp

@@ -119,12 +119,6 @@ TEST_F(MediaCustomControlsFullscreenDetectorTest,

HTMLVideoElement* video =

toHTMLVideoElement(document().createElement("video"));

- EXPECT_FALSE(checkEventListenerRegistered(document(),

- EventTypeNames::fullscreenchange,

- fullscreenDetectorFor(video)));

- EXPECT_FALSE(checkEventListenerRegistered(

- document(), EventTypeNames::webkitfullscreenchange,

- fullscreenDetectorFor(video)));

EXPECT_FALSE(checkEventListenerRegistered(

*video, EventTypeNames::loadedmetadata, fullscreenDetectorFor(video)));

}

@@ -136,11 +130,6 @@ TEST_F(MediaCustomControlsFullscreenDetectorTest,

document().body()->appendChild(video);

EXPECT_TRUE(checkEventListenerRegistered(

- document(), EventTypeNames::fullscreenchange, fullscreenDetector()));

- EXPECT_TRUE(checkEventListenerRegistered(

- document(), EventTypeNames::webkitfullscreenchange,

- fullscreenDetector()));

- EXPECT_TRUE(checkEventListenerRegistered(

*videoElement(), EventTypeNames::loadedmetadata, fullscreenDetector()));

}

@@ -149,11 +138,6 @@ TEST_F(MediaCustomControlsFullscreenDetectorTest,

document().body()->setInnerHTML("<body><video></video></body>");

EXPECT_TRUE(checkEventListenerRegistered(

- document(), EventTypeNames::fullscreenchange, fullscreenDetector()));

- EXPECT_TRUE(checkEventListenerRegistered(

- document(), EventTypeNames::webkitfullscreenchange,

- fullscreenDetector()));

- EXPECT_TRUE(checkEventListenerRegistered(

*videoElement(), EventTypeNames::loadedmetadata, fullscreenDetector()));

}

@@ -165,20 +149,6 @@ TEST_F(MediaCustomControlsFullscreenDetectorTest,

newDocument().body()->appendChild(videoElement());

- EXPECT_FALSE(checkEventListenerRegistered(document(),

- EventTypeNames::fullscreenchange,

- fullscreenDetectorFor(video)));

- EXPECT_FALSE(checkEventListenerRegistered(

- document(), EventTypeNames::webkitfullscreenchange,

- fullscreenDetectorFor(video)));

- EXPECT_TRUE(checkEventListenerRegistered(newDocument(),

- EventTypeNames::fullscreenchange,

- fullscreenDetectorFor(video)));

- EXPECT_TRUE(checkEventListenerRegistered(

- newDocument(), EventTypeNames::webkitfullscreenchange,

- fullscreenDetectorFor(video)));

EXPECT_TRUE(checkEventListenerRegistered(

*video, EventTypeNames::loadedmetadata, fullscreenDetectorFor(video)));

}