Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2793163003: Add EME support for new VP9 codec string in WebM. (Closed)

Created:
3 years, 8 months ago by chcunningham
Modified:
3 years, 8 months ago
CC:
chromium-reviews, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, kqyang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add EME support for new VP9 codec string in WebM. Now supporing "video/webm; codecs=vp09...." in calls to EME's requestForMediaKeySystemAccess(). Must run with the following flag: --enable-new-vp9-codec-string. This CL does not modify existing support for "video/mp4". To enable in MP4 run with --enable-vp9-in-mp4. Runtime flags are checked in MimeUtilInternal ParseVp9CodecID(). BUG=687627 Review-Url: https://codereview.chromium.org/2793163003 Cr-Commit-Position: refs/heads/master@{#462692} Committed: https://chromium.googlesource.com/chromium/src/+/6cfb384ad0513ed6bdf6c6a5886ef5da0411b70a

Patch Set 1 #

Patch Set 2 : Add another debug log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -19 lines) Patch
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 11 chunks +22 lines, -2 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/base/eme_constants.h View 1 chunk +9 lines, -8 lines 0 comments Download
M media/base/key_systems.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M media/base/mime_util_internal.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M media/blink/key_system_config_selector.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
chcunningham
3 years, 8 months ago (2017-04-04 00:25:56 UTC) #4
chcunningham
Friendly ping.
3 years, 8 months ago (2017-04-06 16:57:24 UTC) #11
hubbe
Code looks reasonable to me, but I think you should have it reviewed by someone ...
3 years, 8 months ago (2017-04-06 19:01:26 UTC) #12
chcunningham
+ Dan for EME expertise
3 years, 8 months ago (2017-04-06 19:29:33 UTC) #14
sandersd (OOO until July 31)
lgtm
3 years, 8 months ago (2017-04-06 22:08:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793163003/20001
3 years, 8 months ago (2017-04-06 22:11:08 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 23:57:52 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6cfb384ad0513ed6bdf6c6a5886e...

Powered by Google App Engine
This is Rietveld 408576698