Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: media/base/mime_util_internal.cc

Issue 2793163003: Add EME support for new VP9 codec string in WebM. (Closed)
Patch Set: Add another debug log Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/key_systems.cc ('k') | media/blink/key_system_config_selector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/mime_util_internal.cc
diff --git a/media/base/mime_util_internal.cc b/media/base/mime_util_internal.cc
index 9bb409995088b2a0d77ae2bfd2008796b7a5c229..affb8cc36aeb6869efed4cf3b17f03f8c646f309 100644
--- a/media/base/mime_util_internal.cc
+++ b/media/base/mime_util_internal.cc
@@ -202,12 +202,16 @@ SupportsType MimeUtil::AreSupportedCodecs(
if (!ParseCodecString(mime_type_lower_case, codecs[i], &codec,
&ambiguous_codec_string, &video_profile, &video_level,
&color_space)) {
+ DVLOG(2) << __func__ << " Failed to parse codec string:" << codecs[i];
return IsNotSupported;
}
// Bail if codec not in supported list for given container.
- if (supported_codecs.find(codec) == supported_codecs.end())
+ if (supported_codecs.find(codec) == supported_codecs.end()) {
+ DVLOG(2) << __func__ << " Codec " << codecs[i]
+ << " not supported in container " << mime_type_lower_case;
return IsNotSupported;
+ }
// Make conservative guesses to resolve ambiguity before checking platform
// support. H264 and VP9 are the only allowed ambiguous video codec. DO NOT
@@ -228,8 +232,11 @@ SupportsType MimeUtil::AreSupportedCodecs(
SupportsType result =
IsCodecSupported(mime_type_lower_case, codec, video_profile,
video_level, color_space, is_encrypted);
- if (result == IsNotSupported)
+ if (result == IsNotSupported) {
+ DVLOG(2) << __func__ << " Codec " << codecs[i]
+ << " not supported by platform";
return IsNotSupported;
+ }
// If any codec is "MayBeSupported", return Maybe for the combined result.
// Downgrade to MayBeSupported if we had to guess the meaning of one of the
« no previous file with comments | « media/base/key_systems.cc ('k') | media/blink/key_system_config_selector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698