Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2793033004: Revert of [heap] Fix CompactionSpace test and move to unittests (Closed)

Created:
3 years, 8 months ago by Michael Lippautz
Modified:
3 years, 8 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Fix CompactionSpace test and move to unittests (patchset #3 id:40001 of https://codereview.chromium.org/2796033002/ ) Reason for revert: Breaks https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20shared/builds/17291 Original issue's description: > [heap] Fix CompactionSpace test and move to unittests > > BUG=chromium:651354 > > Review-Url: https://codereview.chromium.org/2796033002 > Cr-Commit-Position: refs/heads/master@{#44382} > Committed: https://chromium.googlesource.com/v8/v8/+/ce9a2db1e13131245d8adc2757b9d9202ba568e0 TBR=ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2793033004 Cr-Commit-Position: refs/heads/master@{#44383} Committed: https://chromium.googlesource.com/v8/v8/+/eddf90c4a750f88c75c11f344675f27942da0400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -55 lines) Patch
M src/heap/heap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D test/unittests/heap/spaces-unittest.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Lippautz
Created Revert of [heap] Fix CompactionSpace test and move to unittests
3 years, 8 months ago (2017-04-04 14:46:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793033004/1
3 years, 8 months ago (2017-04-04 14:47:01 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 14:47:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/eddf90c4a750f88c75c11f344675f27942d...

Powered by Google App Engine
This is Rietveld 408576698