[heap] Fix CompactionSpace test and move to unittests

[heap] Fix CompactionSpace test and move to unittests

BUG=chromium:651354
Review-Url: https://codereview.chromium.org/2796033002
Cr-Commit-Position: refs/heads/master@{#44382}
Committed: https://chromium.googlesource.com/v8/v8/+/ce9a2db1e13131245d8adc2757b9d9202ba568e0

[Michael Lippautz, 2017-04-04 11:45:41]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 11:45:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Lippautz, 2017-04-04 11:45:59]

mlippautz@chromium.org changed reviewers:
+ ulan@chromium.org

[Michael Lippautz, 2017-04-04 11:46:00]

ptal

https://codereview.chromium.org/2796033002/diff/1/test/unittests/heap/spaces-...
File test/unittests/heap/spaces-unittest.cc (right):

https://codereview.chromium.org/2796033002/diff/1/test/unittests/heap/spaces-...
test/unittests/heap/spaces-unittest.cc:27: const int kNumObjects = 10;
Simplified the test:
- Less pages
- No need to create a new allocator and old space.

[ulan, 2017-04-04 11:47:47]

lgtm

[commit-bot: I haz the power, 2017-04-04 11:55:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 11:55:33]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[Michael Lippautz, 2017-04-04 13:07:13]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 13:07:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 13:15:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 13:15:09]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Michael Lippautz, 2017-04-04 13:21:23]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 13:21:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 13:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 13:47:53]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2017-04-04 13:58:35]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2017-04-04 13:58:36]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2796033002/#ps40001
(title: "Win compile failures")

[commit-bot: I haz the power, 2017-04-04 13:58:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 14:28:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491314315889780,
"parent_rev": "10e77dfbaf0bdd8d6ab9202fff1994cf5ce99b5a", "commit_rev":
"ce9a2db1e13131245d8adc2757b9d9202ba568e0"}

[commit-bot: I haz the power, 2017-04-04 14:28:27]

Description was changed from

==========
[heap] Fix CompactionSpace test and move to unittests

BUG=chromium:651354
==========

to

==========
[heap] Fix CompactionSpace test and move to unittests

BUG=chromium:651354

Review-Url: https://codereview.chromium.org/2796033002
Cr-Commit-Position: refs/heads/master@{#44382}
Committed:
https://chromium.googlesource.com/v8/v8/+/ce9a2db1e13131245d8adc2757b9d9202ba...
==========

[commit-bot: I haz the power, 2017-04-04 14:28:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/ce9a2db1e13131245d8adc2757b9d9202ba...

[Michael Lippautz, 2017-04-04 14:46:49]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2793033004/ by mlippautz@chromium.org.

The reason for reverting is: Breaks
https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20sh....

[Michael Achenbach, 2017-04-04 21:19:13]

On 2017/04/04 14:46:49, Michael Lippautz wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2793033004/ by mailto:mlippautz@chromium.org.
> 
> The reason for reverting is: Breaks
>
https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20sh....

FYI: Also failed on tsan:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/14761

[Michael Lippautz, 2017-04-05 07:13:51]

On 2017/04/04 21:19:13, Michael Achenbach wrote:
> On 2017/04/04 14:46:49, Michael Lippautz wrote:
> > A revert of this CL (patchset #3 id:40001) has been created in
> > https://codereview.chromium.org/2793033004/ by
mailto:mlippautz@chromium.org.
> > 
> > The reason for reverting is: Breaks
> >
>
https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20sh....
> 
> FYI: Also failed on tsan:
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/14761

Thanks, this should be unrelated though (I promise! :D)

The CL moves the test test-spaces/CompactionSpace to the unittests and changes
it a bit. As always, it could be related in some unexpected ways though :) 

I will watch the bots when re-landing with my compilation fix.