Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 2792963002: [regexp] Fix check for FLAG_harmony_regexp_dotall (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix check for FLAG_harmony_regexp_dotall Bool flags can be as small as one byte, so testing an IntPtr-sized value is incorrect. BUG=v8:6172 Review-Url: https://codereview.chromium.org/2792963002 Cr-Commit-Position: refs/heads/master@{#44343} Committed: https://chromium.googlesource.com/v8/v8/+/32d4d8e93dda9f8aa069dd5f3f88ba09462ba89d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/builtins/builtins-regexp-gen.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
3 years, 8 months ago (2017-04-03 13:22:15 UTC) #4
Yang
On 2017/04/03 13:22:15, jgruber wrote: lgtm
3 years, 8 months ago (2017-04-03 13:36:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792963002/1
3 years, 8 months ago (2017-04-03 14:35:12 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 14:36:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/32d4d8e93dda9f8aa069dd5f3f88ba09462...

Powered by Google App Engine
This is Rietveld 408576698