Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: src/builtins/builtins-regexp-gen.cc

Issue 2792963002: [regexp] Fix check for FLAG_harmony_regexp_dotall (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-regexp-gen.cc
diff --git a/src/builtins/builtins-regexp-gen.cc b/src/builtins/builtins-regexp-gen.cc
index ee49d8d16bc18a0c9d3dd19b26efbf732f3fd596..b76ee8cec7b39e78592459f93a3702bae43dd6db 100644
--- a/src/builtins/builtins-regexp-gen.cc
+++ b/src/builtins/builtins-regexp-gen.cc
@@ -1368,8 +1368,8 @@ TF_BUILTIN(RegExpPrototypeMultilineGetter, RegExpBuiltinsAssembler) {
Node* RegExpBuiltinsAssembler::IsDotAllEnabled(Isolate* isolate) {
Node* flag_ptr = ExternalConstant(
ExternalReference::address_of_regexp_dotall_flag(isolate));
- Node* flag_value = Load(MachineType::IntPtr(), flag_ptr);
- return WordNotEqual(flag_value, IntPtrConstant(0));
+ Node* const flag_value = Load(MachineType::Int8(), flag_ptr);
+ return Word32NotEqual(flag_value, Int32Constant(0));
}
// ES #sec-get-regexp.prototype.dotAll
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698