Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2792933003: Remove duplicate using statement. (Closed)

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 8 months ago
Reviewers:
haraken, jsbell
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, cmumford
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate using statement. One "using namespace WTF::Unicode" is enough, and actually might be one too many if the Chromium coding style is adapted in blink. This caused a bit of a problem when experimenting with unity builds. R=jsbell@chromium.org Review-Url: https://codereview.chromium.org/2792933003 Cr-Commit-Position: refs/heads/master@{#461686} Committed: https://chromium.googlesource.com/chromium/src/+/1cf6b687dc4c48f4a8f4d4e8589a7a0a9c5f9957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/indexeddb/IDBKeyPath.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Daniel Bratell
3 years, 8 months ago (2017-04-03 16:44:50 UTC) #1
haraken
LGTM
3 years, 8 months ago (2017-04-03 23:51:25 UTC) #2
jsbell
lgtm - at least I didn't add more after 2013. :S
3 years, 8 months ago (2017-04-04 00:10:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792933003/1
3 years, 8 months ago (2017-04-04 10:06:08 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 12:34:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1cf6b687dc4c48f4a8f4d4e8589a...

Powered by Google App Engine
This is Rietveld 408576698