android: Post warmup to launcher thread

android: Post warmup to launcher thread

Then simplify all callsites to just call warmup on UI thread.

Test got a bit more complicated with the new restriction that
warmUp must be called on the UI thread.

BUG=689758
Review-Url: https://codereview.chromium.org/2792873003
Cr-Commit-Position: refs/heads/master@{#462158}
Committed: https://chromium.googlesource.com/chromium/src/+/52a60f52642d164a8f83cdf2a8c37beb8e26c898

[boliu, 2017-04-03 15:14:03]

Description was changed from

==========
android: Post warmup to launcher thread

Then simplify all callsites to just call warmup on UI thread.

BUG=689758
==========

to

==========
android: Post warmup to launcher thread

Then simplify all callsites to just call warmup on UI thread.

Test got a bit more complicated with the new restriction that
warmUp must be called on the UI thread.

BUG=689758
==========

[boliu, 2017-04-03 15:17:50]

boliu@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[boliu, 2017-04-03 15:17:51]

ptal

[boliu, 2017-04-03 15:17:57]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 15:18:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-04-03 16:09:56]

The CQ bit was unchecked by boliu@chromium.org

[boliu, 2017-04-03 16:35:13]

On 2017/04/03 15:17:51, boliu wrote:
> ptal

Err.. looks like there's a failing test. Can hold off review while I look into
that

[boliu, 2017-04-03 18:31:00]

On 2017/04/03 16:35:13, boliu wrote:
> On 2017/04/03 15:17:51, boliu wrote:
> > ptal
> 
> Err.. looks like there's a failing test. Can hold off review while I look into
> that

Ok, PTAL. No change needed here. The fix for the failing test is here:
https://codereview.chromium.org/2793903003/#

The issue is @CommandLineFlags.Add("foo=bar") doesn't work, but only when the
java-only CommandLine instance is in use. So any test that adds switch with
value, and have code read the value on start up is racy. In this case, warmUp
got moved earlier, apparently. Test was probably flaky before, and this change
just made it fail consistently.

[Maria, 2017-04-05 17:44:23]

lgtm

https://codereview.chromium.org/2792873003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java
(right):

https://codereview.chromium.org/2792873003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java:101:
}
Hmm, I hope that doing warm-up in parallel with the library load won't cause
both to slow down.

[boliu, 2017-04-05 17:52:58]

https://codereview.chromium.org/2792873003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java
(right):

https://codereview.chromium.org/2792873003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java:101:
}
On 2017/04/05 17:44:23, Maria wrote:
> Hmm, I hope that doing warm-up in parallel with the library load won't cause
> both to slow down.

Land this and watch the perf bots I guess..

[boliu, 2017-04-05 17:53:15]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2017-04-05 17:53:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Maria, 2017-04-05 17:53:42]

On 2017/04/05 17:52:58, boliu wrote:
>
https://codereview.chromium.org/2792873003/diff/40001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java
> (right):
> 
>
https://codereview.chromium.org/2792873003/diff/40001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java:101:
> }
> On 2017/04/05 17:44:23, Maria wrote:
> > Hmm, I hope that doing warm-up in parallel with the library load won't cause
> > both to slow down.
> 
> Land this and watch the perf bots I guess..

Yeah, that should be fine.

[commit-bot: I haz the power, 2017-04-05 18:45:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491414795260130,
"parent_rev": "0972b62fed235a17841193d7e6b793622115aa26", "commit_rev":
"52a60f52642d164a8f83cdf2a8c37beb8e26c898"}

[commit-bot: I haz the power, 2017-04-05 18:46:47]

Description was changed from

==========
android: Post warmup to launcher thread

Then simplify all callsites to just call warmup on UI thread.

Test got a bit more complicated with the new restriction that
warmUp must be called on the UI thread.

BUG=689758
==========

to

==========
android: Post warmup to launcher thread

Then simplify all callsites to just call warmup on UI thread.

Test got a bit more complicated with the new restriction that
warmUp must be called on the UI thread.

BUG=689758

Review-Url: https://codereview.chromium.org/2792873003
Cr-Commit-Position: refs/heads/master@{#462158}
Committed:
https://chromium.googlesource.com/chromium/src/+/52a60f52642d164a8f83cdf2a8c3...
==========

[commit-bot: I haz the power, 2017-04-05 18:46:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/52a60f52642d164a8f83cdf2a8c3...