Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java

Issue 2792873003: android: Post warmup to launcher thread (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java b/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java
index 4ad3136de67419162bb3d4829bf50359e985df02..2fc7507548be36c441604bec311928253fc4c7b7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java
@@ -36,9 +36,9 @@ public abstract class AsyncInitTaskRunner {
return ChromeVersionInfo.isOfficialBuild();
}
- private class LoadTask extends AsyncTask<Boolean, Void, Boolean> {
+ private class LoadTask extends AsyncTask<Void, Void, Boolean> {
@Override
- protected Boolean doInBackground(Boolean... allocateChildConnection) {
+ protected Boolean doInBackground(Void... params) {
try {
LibraryLoader libraryLoader = LibraryLoader.get(LibraryProcessType.PROCESS_BROWSER);
libraryLoader.ensureInitialized();
@@ -56,9 +56,6 @@ public abstract class AsyncInitTaskRunner {
} catch (ProcessInitException e) {
return false;
}
- if (allocateChildConnection[0]) {
- ChildProcessLauncher.warmUp(ContextUtils.getApplicationContext());
- }
return true;
}
@@ -99,8 +96,11 @@ public abstract class AsyncInitTaskRunner {
mFetchSeedTask.executeOnExecutor(getExecutor());
}
+ if (allocateChildConnection) {
+ ChildProcessLauncher.warmUp(ContextUtils.getApplicationContext());
+ }
Maria 2017/04/05 17:44:23 Hmm, I hope that doing warm-up in parallel with th
boliu 2017/04/05 17:52:58 Land this and watch the perf bots I guess..
mLoadTask = new LoadTask();
- mLoadTask.executeOnExecutor(getExecutor(), allocateChildConnection);
+ mLoadTask.executeOnExecutor(getExecutor());
}
private void tasksPossiblyComplete(boolean result) {

Powered by Google App Engine
This is Rietveld 408576698