Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2792853002: Revert of Don't require DEPS OWNERS when moving lines around in a DEPS file. (Closed)

Created:
3 years, 8 months ago by Sam McNally
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, dcheng
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't require DEPS OWNERS when moving lines around in a DEPS file. (patchset #3 id:40001 of https://codereview.chromium.org/2768063004/ ) Reason for revert: Breaks presubmit when adding DEPS files: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Fchromium_presubmit%2F400708%2F%2B%2Frecipes%2Fsteps%2Fpresubmit%2F0%2Fstdout Original issue's description: > Don't require DEPS OWNERS when moving lines around in a DEPS file. > > As a bonus, less regex than before and also correctly handles the > '!' prefix in DEPS files now. > > BUG=702851 > R=dpranke@chromium.org > > Review-Url: https://codereview.chromium.org/2768063004 > Cr-Commit-Position: refs/heads/master@{#461266} > Committed: https://chromium.googlesource.com/chromium/src/+/da9479f3d2ff217723adc834581d41671c18d06c TBR=dpranke@chromium.org,dcheng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=702851 Review-Url: https://codereview.chromium.org/2792853002 Cr-Commit-Position: refs/heads/master@{#461358} Committed: https://chromium.googlesource.com/chromium/src/+/be5ca3ea5d86ccc88ff78f5f0ff7cd5c8e796196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -140 lines) Patch
M PRESUBMIT.py View 4 chunks +25 lines, -70 lines 0 comments Download
M PRESUBMIT_test.py View 2 chunks +33 lines, -70 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam McNally
Created Revert of Don't require DEPS OWNERS when moving lines around in a DEPS file.
3 years, 8 months ago (2017-04-03 01:32:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792853002/1
3 years, 8 months ago (2017-04-03 01:32:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/be5ca3ea5d86ccc88ff78f5f0ff7cd5c8e796196
3 years, 8 months ago (2017-04-03 01:49:30 UTC) #6
dcheng
Sigh. LGTM.
3 years, 8 months ago (2017-04-03 01:53:43 UTC) #7
Dirk Pranke
3 years, 8 months ago (2017-04-03 02:35:23 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698