Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2768063004: Don't require DEPS OWNERS when moving lines around in a DEPS file. (Closed)

Created:
3 years, 9 months ago by dcheng
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't require DEPS OWNERS when moving lines around in a DEPS file. As a bonus, less regex than before and also correctly handles the '!' prefix in DEPS files now. BUG=702851 R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2768063004 Cr-Commit-Position: refs/heads/master@{#461266} Committed: https://chromium.googlesource.com/chromium/src/+/da9479f3d2ff217723adc834581d41671c18d06c

Patch Set 1 #

Patch Set 2 : Support more complex DEPS syntax in root DEPS file #

Patch Set 3 : Revert test DEPS change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -56 lines) Patch
M PRESUBMIT.py View 1 4 chunks +69 lines, -24 lines 0 comments Download
M PRESUBMIT_test.py View 2 chunks +69 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dcheng
Please compare PS1 (original) and PS3 (with special parsing). It feels kind of lame to ...
3 years, 9 months ago (2017-03-23 05:40:25 UTC) #1
dcheng
ping =)
3 years, 9 months ago (2017-03-24 18:37:56 UTC) #2
dcheng
ping =)
3 years, 8 months ago (2017-03-28 15:51:43 UTC) #3
Dirk Pranke
lgtm
3 years, 8 months ago (2017-03-31 22:50:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768063004/40001
3 years, 8 months ago (2017-03-31 22:54:03 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/da9479f3d2ff217723adc834581d41671c18d06c
3 years, 8 months ago (2017-03-31 23:10:32 UTC) #9
Sam McNally
3 years, 8 months ago (2017-04-03 01:32:23 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2792853002/ by sammc@chromium.org.

The reason for reverting is: Breaks presubmit when adding DEPS files:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux....

Powered by Google App Engine
This is Rietveld 408576698