Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2792683002: cache_invalidation: Restrict background services only on O. (Closed)

Created:
3 years, 8 months ago by Khushal
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

cache_invalidation: Restrict background services only on O. Starting/Stoping the invalidation client requires starting a service which should be gated on O builds only. Since the current check uses isGreaterThanN, which is still true for certain N builds, use isGreaterThanO instead. BUG=706956 Review-Url: https://codereview.chromium.org/2790703002 Cr-Commit-Position: refs/heads/master@{#460864} (cherry picked from commit faa4d68dd2fec796031ce483ef8aed4929bef34c) Review-Url: https://codereview.chromium.org/2792683002 . Cr-Commit-Position: refs/branch-heads/3029@{#519} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/9266031a6c59f20cdab0e500ecc742a31695548a

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Khushal
3 years, 8 months ago (2017-03-31 21:31:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9266031a6c59f20cdab0e500ecc742a31695548a.

Powered by Google App Engine
This is Rietveld 408576698