Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2790703002: cache_invalidation: Restrict background services only on O. (Closed)

Created:
3 years, 8 months ago by Khushal
Modified:
3 years, 8 months ago
Reviewers:
nyquist, Nicolas Zea
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cache_invalidation: Restrict background services only on O. Starting/Stoping the invalidation client requires starting a service which should be gated on O builds only. Since the current check uses isGreaterThanN, which is still true for certain N builds, use isGreaterThanO instead. BUG=706956 Review-Url: https://codereview.chromium.org/2790703002 Cr-Commit-Position: refs/heads/master@{#460864} Committed: https://chromium.googlesource.com/chromium/src/+/faa4d68dd2fec796031ce483ef8aed4929bef34c

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
Khushal
3 years, 8 months ago (2017-03-30 19:18:08 UTC) #2
nyquist
lgtm
3 years, 8 months ago (2017-03-30 19:21:49 UTC) #3
Nicolas Zea
LGTM but please add a bug so we can request a merge to m58
3 years, 8 months ago (2017-03-30 19:22:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790703002/1
3 years, 8 months ago (2017-03-30 19:23:59 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 20:37:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/faa4d68dd2fec796031ce483ef8a...

Powered by Google App Engine
This is Rietveld 408576698