Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2792653002: Fix garbage collection with ColdModeSpellCheckRequester (Closed)

Created:
3 years, 8 months ago by Xiaocheng
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine, Xiaocheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix garbage collection with ColdModeSpellCheckRequester This patch makes ColdModeSpellCheckRequester inherit from GarbageCollected<> becuase it doesn't need finalization. It also moves DECLARE_TRACE to public section for better coding style. BUG=n/a Review-Url: https://codereview.chromium.org/2792653002 Cr-Commit-Position: refs/heads/master@{#461368} Committed: https://chromium.googlesource.com/chromium/src/+/021c7e1715272a2fdf05030874e4b76ca3e340bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Xiaocheng
PTAL.
3 years, 8 months ago (2017-03-31 20:32:43 UTC) #4
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-03 01:57:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792653002/1
3 years, 8 months ago (2017-04-03 01:57:43 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 04:04:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/021c7e1715272a2fdf05030874e4...

Powered by Google App Engine
This is Rietveld 408576698