Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.h

Issue 2792653002: Fix garbage collection with ColdModeSpellCheckRequester (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.h
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.h b/third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.h
index 5f7dc52e0e10633b68d7ad3abd540a25063b6eba..3bb630ddd50293fc53bc1fafed9ed1ff5c01740d 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.h
+++ b/third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.h
@@ -16,10 +16,9 @@ class SpellCheckRequester;
// This class is only supposed to be used by IdleSpellCheckCallback in cold mode
// invocation. Not to be confused with SpellCheckRequester.
class ColdModeSpellCheckRequester
- : public GarbageCollectedFinalized<ColdModeSpellCheckRequester> {
+ : public GarbageCollected<ColdModeSpellCheckRequester> {
public:
static ColdModeSpellCheckRequester* create(LocalFrame&);
- ~ColdModeSpellCheckRequester();
void setNeedsMoreInvocationForTesting() {
m_needsMoreInvocationForTesting = true;
@@ -28,6 +27,8 @@ class ColdModeSpellCheckRequester
void invoke(IdleDeadline*);
bool fullDocumentChecked() const;
+ DECLARE_TRACE();
+
private:
explicit ColdModeSpellCheckRequester(LocalFrame&);
@@ -55,7 +56,6 @@ class ColdModeSpellCheckRequester
uint64_t m_lastCheckedDOMTreeVersion;
mutable bool m_needsMoreInvocationForTesting;
- DECLARE_TRACE();
DISALLOW_COPY_AND_ASSIGN(ColdModeSpellCheckRequester);
};
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698