Separate the parent directory link in FTP listings.

Separate the parent directory link in FTP listings.

Thus it won't get sorted along with the rest of the file listings and
end up on the bottom.

BUG=641097
Review-Url: https://codereview.chromium.org/2792533003
Cr-Commit-Position: refs/heads/master@{#466103}
Committed: https://chromium.googlesource.com/chromium/src/+/9719cebca5c0195cbac3e23a8ec9a363c78932f1

[Lei Zhang, 2017-04-01 02:35:34]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-01 02:35:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-01 03:29:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-01 03:29:08]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-04-01 05:06:35]

thestig@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Lei Zhang, 2017-04-01 05:06:35]

I'm not a UI designer, but I clobbered this together. WDYT?

[Paweł Hajdan Jr., 2017-04-03 20:05:32]

phajdan.jr@chromium.org changed reviewers:
+ eroman@chromium.org

[Paweł Hajdan Jr., 2017-04-03 20:05:32]

+eroman

Lei, thanks for the changes. Could you do screenshots before/after for
evaluating visible effects of this change?

[Lei Zhang, 2017-04-04 05:56:38]

On 2017/04/03 20:05:32, Paweł Hajdan Jr. wrote:
> +eroman
> 
> Lei, thanks for the changes. Could you do screenshots before/after for
> evaluating visible effects of this change?

It literally looks like the current look but with the parent directory link
moved to the top. You can easily see the "before" look in your browser. This is
"after": https://drive.google.com/file/d/0B5yuieQYffwPQWpHQkRlQVZUa2c/view

[eroman, 2017-04-04 19:24:08]

lgtm

https://codereview.chromium.org/2792533003/diff/1/net/base/dir_header.html
File net/base/dir_header.html (right):

https://codereview.chromium.org/2792533003/diff/1/net/base/dir_header.html#ne...
net/base/dir_header.html:76: if (root.substr(-1) !== "/")
root.endsWith("/")

[Paweł Hajdan Jr., 2017-04-06 12:51:56]

LGTM

[Lei Zhang, 2017-04-18 05:53:11]

https://codereview.chromium.org/2792533003/diff/1/net/base/dir_header.html
File net/base/dir_header.html (right):

https://codereview.chromium.org/2792533003/diff/1/net/base/dir_header.html#ne...
net/base/dir_header.html:76: if (root.substr(-1) !== "/")
On 2017/04/04 19:24:08, eroman wrote:
> root.endsWith("/")

Done, with a ! in front.

[Lei Zhang, 2017-04-18 05:53:28]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2017-04-18 05:53:29]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org,
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2792533003/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2017-04-18 05:53:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 06:01:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 06:01:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Lei Zhang, 2017-04-18 06:11:48]

thestig@chromium.org changed reviewers:
+ clamy@chromium.org

[Lei Zhang, 2017-04-18 06:11:49]

+clamy for content/OWNERS

Forgot to mention I slacked off on this on purpose so this lands early in M60
rather than late in M59. Gives us more time to get feedback and tweak the UI if
needed without needing to merge to M59.

[Lei Zhang, 2017-04-20 08:15:06]

On 2017/04/18 06:11:49, Lei Zhang wrote:
> +clamy for content/OWNERS
> 
> Forgot to mention I slacked off on this on purpose so this lands early in M60
> rather than late in M59. Gives us more time to get feedback and tweak the UI
if
> needed without needing to merge to M59.

ping.

[clamy, 2017-04-20 17:08:57]

Thanks for the cleanup. Lgtm.

[Lei Zhang, 2017-04-20 19:09:14]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2017-04-20 19:09:14]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org,
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2792533003/#ps60001
(title: "Fix comment not converted by Blink mass reformatting")

[commit-bot: I haz the power, 2017-04-20 19:10:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 20:20:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492715354218000,
"parent_rev": "c2c4dc334bd323be6096f6bec6836e0d7be700c6", "commit_rev":
"9719cebca5c0195cbac3e23a8ec9a363c78932f1"}

[commit-bot: I haz the power, 2017-04-20 20:20:56]

Description was changed from

==========
Separate the parent directory link in FTP listings.

Thus it won't get sorted along with the rest of the file listings and
end up on the bottom.

BUG=641097
==========

to

==========
Separate the parent directory link in FTP listings.

Thus it won't get sorted along with the rest of the file listings and
end up on the bottom.

BUG=641097

Review-Url: https://codereview.chromium.org/2792533003
Cr-Commit-Position: refs/heads/master@{#466103}
Committed:
https://chromium.googlesource.com/chromium/src/+/9719cebca5c0195cbac3e23a8ec9...
==========

[commit-bot: I haz the power, 2017-04-20 20:20:58]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9719cebca5c0195cbac3e23a8ec9...