Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2823173003: Improve error handling in FtpDirectoryListingResponseDelegate. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, Paweł Hajdan Jr.
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Not Ready For Review - red bots Improve error handling in FtpDirectoryListingResponseDelegate. This makes the failing directory listing in the bug print an error at least. Do some more cleanup in the modified files. BUG=633841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M content/child/ftp_directory_listing_response_delegate.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/child/ftp_directory_listing_response_delegate.cc View 4 chunks +14 lines, -11 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 2792533003 Patch 60001

Messages

Total messages: 7 (7 generated)
Lei Zhang
Description was changed from ========== Improve error handling in FtpDirectoryListingResponseDelegate. This makes the failing directory ...
3 years, 8 months ago (2017-04-18 08:32:32 UTC) #1
Lei Zhang
thestig@chromium.org changed reviewers: + eroman@chromium.org, mmenke@chromium.org, phajdan.jr@chromium.org
3 years, 8 months ago (2017-04-18 08:32:32 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-18 08:34:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823173003/1
3 years, 8 months ago (2017-04-18 08:34:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-18 08:53:27 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/364651)
3 years, 8 months ago (2017-04-18 08:53:28 UTC) #6
Lei Zhang
3 years, 8 months ago (2017-04-18 09:11:42 UTC) #7 
Description was changed from

==========
Improve error handling in FtpDirectoryListingResponseDelegate.

This makes the failing directory listing in the bug print an error at
least.

Do some more cleanup in the modified files.

BUG=633841
==========

to

==========
Not Ready For Review - red bots

Improve error handling in FtpDirectoryListingResponseDelegate.

This makes the failing directory listing in the bug print an error at
least.

Do some more cleanup in the modified files.

BUG=633841
==========

Powered by Google App Engine
This is Rietveld 408576698