[CrOS Tether] Create TetherConnector, which attempts to connect to a nearby tether host.

[CrOS Tether] Create TetherConnector, which attempts to connect to a nearby tether host.

This class covers the entire connection process, from a UI callback (when the user clicks a tether network) to connecting to the associated device's Wi-Fi network.

BUG=672263
Review-Url: https://codereview.chromium.org/2792483002
Cr-Commit-Position: refs/heads/master@{#462712}
Committed: https://chromium.googlesource.com/chromium/src/+/1d73b1aebe5f3a978a5a87c7502689b49ba1b134

[Kyle Horimoto, 2017-04-05 19:02:49]

khorimoto@chromium.org changed reviewers:
+ hansberry@chromium.org

[Ryan Hansberry, 2017-04-06 02:17:44]

https://codereview.chromium.org/2792483002/diff/80001/chromeos/components/tet...
File chromeos/components/tether/tether_connector.cc (right):

https://codereview.chromium.org/2792483002/diff/80001/chromeos/components/tet...
chromeos/components/tether/tether_connector.cc:124:
connect_tethering_operation_.reset();
You are deleting connect_tethering_operation_ here, but below pass its ssid and
password members (look at how ConnectTetheringResponse calls on
OnSuccessfulConnectTetheringResponse). This causes a crash. A copy of the ssid
and password needs to occur somewhere (probably in ConnectTetheringResponse
right before calling OnSuccessfulConnectTetheringResponse), before deleting
connect_tethering_operation_.

[Kyle Horimoto, 2017-04-06 17:10:54]

https://codereview.chromium.org/2792483002/diff/80001/chromeos/components/tet...
File chromeos/components/tether/tether_connector.cc (right):

https://codereview.chromium.org/2792483002/diff/80001/chromeos/components/tet...
chromeos/components/tether/tether_connector.cc:124:
connect_tethering_operation_.reset();
On 2017/04/06 02:17:44, Ryan Hansberry wrote:
> You are deleting connect_tethering_operation_ here, but below pass its ssid
and
> password members (look at how ConnectTetheringResponse calls on
> OnSuccessfulConnectTetheringResponse). This causes a crash. A copy of the ssid
> and password needs to occur somewhere (probably in ConnectTetheringResponse
> right before calling OnSuccessfulConnectTetheringResponse), before deleting
> connect_tethering_operation_.

Done.

[Ryan Hansberry, 2017-04-06 17:21:03]

lgtm

[Jeremy Klein, 2017-04-06 21:04:13]

jlklein@chromium.org changed reviewers:
+ jlklein@chromium.org

[Jeremy Klein, 2017-04-06 21:04:15]

lgtm

https://codereview.chromium.org/2792483002/diff/100001/chromeos/components/te...
File chromeos/components/tether/connect_tethering_operation.h (right):

https://codereview.chromium.org/2792483002/diff/100001/chromeos/components/te...
chromeos/components/tether/connect_tethering_operation.h:93:
ConnectTetheringResponse_ResponseCode error_code_to_return_;
nit: I'd call this response_code_to_return to match the type.

[Kyle Horimoto, 2017-04-06 21:33:53]

https://codereview.chromium.org/2792483002/diff/100001/chromeos/components/te...
File chromeos/components/tether/connect_tethering_operation.h (right):

https://codereview.chromium.org/2792483002/diff/100001/chromeos/components/te...
chromeos/components/tether/connect_tethering_operation.h:93:
ConnectTetheringResponse_ResponseCode error_code_to_return_;
On 2017/04/06 21:04:15, Jeremy Klein wrote:
> nit: I'd call this response_code_to_return to match the type.

I'd like to keep it as is. We only use that variable when an error occurs, so
the naming was intentional.

[Kyle Horimoto, 2017-04-06 21:33:59]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2017-04-06 21:35:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 23:34:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 23:34:52]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Kyle Horimoto, 2017-04-06 23:37:16]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2017-04-06 23:38:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 00:40:09]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491521836009270,
"parent_rev": "5ada6f1b43bfc2bdc326d0ff7ff808b4340479cc", "commit_rev":
"1d73b1aebe5f3a978a5a87c7502689b49ba1b134"}

[commit-bot: I haz the power, 2017-04-07 00:41:02]

Description was changed from

==========
[CrOS Tether] Create TetherConnector, which attempts to connect to a nearby
tether host.

This class covers the entire connection process, from a UI callback (when the
user clicks a tether network) to connecting to the associated device's Wi-Fi
network.

BUG=672263
==========

to

==========
[CrOS Tether] Create TetherConnector, which attempts to connect to a nearby
tether host.

This class covers the entire connection process, from a UI callback (when the
user clicks a tether network) to connecting to the associated device's Wi-Fi
network.

BUG=672263

Review-Url: https://codereview.chromium.org/2792483002
Cr-Commit-Position: refs/heads/master@{#462712}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d73b1aebe5f3a978a5a87c75026...
==========

[commit-bot: I haz the power, 2017-04-07 00:41:03]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/1d73b1aebe5f3a978a5a87c75026...