[CrOS Tether] Create TetherConnector, which attempts to connect to a nearby tether host.

chromeos/components/tether/connect_tethering_operation.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_COMPONENTS_TETHER_CONNECT_TETHERING_OPERATION_H_
 #define CHROMEOS_COMPONENTS_TETHER_CONNECT_TETHERING_OPERATION_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 32 matching lines @@
         BleConnectionManager* connection_manager,
         HostScanDevicePrioritizer* host_scan_device_prioritizer);
 
    private:
     static Factory* factory_instance_;
   };
 
   class Observer {
    public:
     virtual void OnSuccessfulConnectTetheringResponse(
+        const cryptauth::RemoteDevice& remote_device,
         const std::string& ssid,
         const std::string& password) = 0;
     virtual void OnConnectTetheringFailure(
+        const cryptauth::RemoteDevice& remote_device,
         ConnectTetheringResponse_ResponseCode error_code) = 0;
   };
 
   ConnectTetheringOperation(
       const cryptauth::RemoteDevice& device_to_connect,
       BleConnectionManager* connection_manager,
       HostScanDevicePrioritizer* host_scan_device_prioritizer);
   ~ConnectTetheringOperation() override;
 
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
  protected:
   // MessageTransferOperation:
   void OnDeviceAuthenticated(
       const cryptauth::RemoteDevice& remote_device) override;
   void OnMessageReceived(std::unique_ptr<MessageWrapper> message_wrapper,
                          const cryptauth::RemoteDevice& remote_device) override;
   void OnOperationFinished() override;
   MessageType GetMessageTypeForConnection() override;
-
- private:
-  friend class ConnectTetheringOperationTest;
-
   void NotifyObserversOfSuccessfulResponse(const std::string& ssid,
                                            const std::string& password);
   void NotifyObserversOfConnectionFailure(
       ConnectTetheringResponse_ResponseCode error_code);
 
+ private:
+  friend class ConnectTetheringOperationTest;
+
+  cryptauth::RemoteDevice remote_device_;
   HostScanDevicePrioritizer* host_scan_device_prioritizer_;
-  bool has_authenticated_;
+
+  // These values are saved in OnMessageReceived() and returned in
+  // OnOperationFinished().
+  std::string ssid_to_return_;
+  std::string password_to_return_;
+  ConnectTetheringResponse_ResponseCode error_code_to_return_;

[Jeremy Klein, 2017/04/06 21:04:15]

nit: I'd call this response_code_to_return to match the type.

[Kyle Horimoto, 2017/04/06 21:33:52]

I'd like to keep it as is. We only use that variable when an error occurs, so
the naming was intentional.

+
   base::ObserverList<Observer> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(ConnectTetheringOperation);
 };
 
 }  // namespace tether
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_COMPONENTS_TETHER_CONNECT_TETHERING_OPERATION_H_