Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2792193003: web_dev_style: make CSS checker ignore /* <tags> in comments */ (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
tsergeant
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

web_dev_style: make CSS checker ignore /* <tags> in comments */ R=tsergeant@chromium.org BUG=708004 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2792193003 Cr-Commit-Position: refs/heads/master@{#461627} Committed: https://chromium.googlesource.com/chromium/src/+/cd18607d7cd03eb9486c028a09e98c514e9987c7

Patch Set 1 #

Patch Set 2 : fix settings_shared_css.html #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M chrome/browser/resources/settings/settings_shared_css.html View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/web_dev_style/css_checker.py View 1 chunk +11 lines, -8 lines 0 comments Download
M chrome/browser/web_dev_style/css_checker_test.py View 3 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Dan Beam
3 years, 8 months ago (2017-04-04 00:27:20 UTC) #1
tsergeant
lgtm, I'm glad there was a si͏m̶p̛l̀e ҉so͡lution
3 years, 8 months ago (2017-04-04 00:47:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792193003/20001
3 years, 8 months ago (2017-04-04 02:16:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/183090) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-04 02:19:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792193003/40001
3 years, 8 months ago (2017-04-04 03:00:43 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 04:15:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cd18607d7cd03eb9486c028a09e9...

Powered by Google App Engine
This is Rietveld 408576698