chrome/browser/web_dev_style/css_checker_test.py - Issue 2792193003: web_dev_style: make CSS checker ignore /* <tags> in comments */

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_dev_style/css_checker_test.py

Issue 2792193003: web_dev_style: make CSS checker ignore /* <tags> in comments */ (Closed)

Patch Set: merge Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/web_dev_style/css_checker_test.py

diff --git a/chrome/browser/web_dev_style/css_checker_test.py b/chrome/browser/web_dev_style/css_checker_test.py

index d7f9515ee1cec189d39d0e444cbe04cdd8e485be..6046ea583f741114ed90daef9cba18c50959a53c 100755

--- a/chrome/browser/web_dev_style/css_checker_test.py

+++ b/chrome/browser/web_dev_style/css_checker_test.py

@@ -461,7 +461,7 @@ body.alternate-logo #logo {

width: 0in;

""")

- def testHtmlInlineStyle(self):

+ def testInlineStyleInHtml(self):

self.VerifyContentsProducesOutput("""<!doctype html>

<html>

<head>

@@ -483,10 +483,10 @@ body.alternate-logo #logo {

flex-direction:column;

""", filename='test.html')

- def testHtmlIncludeStyle(self):

+ def testInlineStyleInHtmlWithIncludes(self):

self.VerifyContentsProducesOutput("""<!doctype html>

<html>

- <style include="fake-shared-css">

+ <style include="fake-shared-css other-shared-css">

body {

flex-direction:column;

}

@@ -497,6 +497,21 @@ body.alternate-logo #logo {

flex-direction:column;

""", filename='test.html')

+ def testInlineSTyleInHtmlWithTagsInComments(self):

+ self.VerifyContentsProducesOutput("""<!doctype html>

+<html>

+ <style>

+ body {

+ /* You better ignore the <tag> in this comment! */

+ flex-direction:column;

+ }

+ </style>

+</head>

+</html>""", """

+- Colons (:) should have a space after them.

+ flex-direction:column;

+""", filename='test.html')

if __name__ == '__main__':

unittest.main()

« no previous file with comments | « chrome/browser/web_dev_style/css_checker.py ('k') | no next file » | no next file with comments »