Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2792143002: cc: Avoid Crash in Effect Tree Animation by Element ID (Closed)

Created:
3 years, 8 months ago by weiliangc
Modified:
3 years, 8 months ago
Reviewers:
wkorman
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3061
Project:
chromium
Visibility:
Public.

Description

cc: Avoid Crash in Effect Tree Animation by Element ID Instead of crash, early out of function trying to animate on effect tree by element id. The root cause of this crash is we are trying to animate a node that does not have element id set up in map yet. Before the bug was covered by operator[] used for access map, and that would ends up being a noop. R=wkorman BUG=706766, 707090, 702774 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2794673002 Cr-Commit-Position: refs/heads/master@{#461432} (cherry picked from commit 9975ad63f85f1fe76100602db98800b9232aa454) Review-Url: https://codereview.chromium.org/2792143002 . Cr-Commit-Position: refs/branch-heads/3061@{#3} Cr-Branched-From: 9e03960f75b3019372157db5c4fe5264dfc36616-refs/heads/master@{#461353} Committed: https://chromium.googlesource.com/chromium/src/+/9a3acfa5090cb502ba1af13609446a6b9a052dad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M cc/trees/property_tree.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
weiliangc
3 years, 8 months ago (2017-04-03 20:18:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a3acfa5090cb502ba1af13609446a6b9a052dad.

Powered by Google App Engine
This is Rietveld 408576698