Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2794673002:
cc: Avoid Crash in Effect Tree Animation by Element ID (Closed)
Descriptioncc: Avoid Crash in Effect Tree Animation by Element ID
Instead of crash, early out of function trying to animate on effect
tree by element id.
The root cause of this crash is we are trying to animate a node that
does not have element id set up in map yet. Before the bug was covered
by operator[] used for access map, and that would ends up being a noop.
R=wkorman
BUG=706766, 707090, 702774
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2794673002
Cr-Commit-Position: refs/heads/master@{#461432}
Committed: https://chromium.googlesource.com/chromium/src/+/9975ad63f85f1fe76100602db98800b9232aa454
Patch Set 1 #Patch Set 2 : fix compile error w/ no return value #Messages
Total messages: 19 (13 generated)
Description was changed from ========== cc: Avoid Crash in Effect Tree Animation by Element ID Instead of crash, early out of function trying to animate on effect tree by element id. The root cause of this crash is we are trying to animate a node that does not have element id set up in map yet. Before the bug was covered by operator[] used for access map, and that would ends up being a noop. R=wkorman BUG=706766 ========== to ========== cc: Avoid Crash in Effect Tree Animation by Element ID Instead of crash, early out of function trying to animate on effect tree by element id. The root cause of this crash is we are trying to animate a node that does not have element id set up in map yet. Before the bug was covered by operator[] used for access map, and that would ends up being a noop. R=wkorman BUG=706766 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
lgtm
The CQ bit was checked by weiliangc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by weiliangc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== cc: Avoid Crash in Effect Tree Animation by Element ID Instead of crash, early out of function trying to animate on effect tree by element id. The root cause of this crash is we are trying to animate a node that does not have element id set up in map yet. Before the bug was covered by operator[] used for access map, and that would ends up being a noop. R=wkorman BUG=706766 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== cc: Avoid Crash in Effect Tree Animation by Element ID Instead of crash, early out of function trying to animate on effect tree by element id. The root cause of this crash is we are trying to animate a node that does not have element id set up in map yet. Before the bug was covered by operator[] used for access map, and that would ends up being a noop. R=wkorman BUG=706766, 707090, 702774 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by weiliangc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org Link to the patchset: https://codereview.chromium.org/2794673002/#ps20001 (title: "fix compile error w/ no return value")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491229258049570,
"parent_rev": "e8cc5ba9a51193c5759e775c263d2266e84a4a82", "commit_rev":
"54261e08fd62950e0893a06dcd2027bf9c961fdc"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491229258049570,
"parent_rev": "ff1e89b63f0ffb16a7f5c17e3afc29b35b2226f5", "commit_rev":
"9975ad63f85f1fe76100602db98800b9232aa454"}
Message was sent while issue was closed.
Description was changed from ========== cc: Avoid Crash in Effect Tree Animation by Element ID Instead of crash, early out of function trying to animate on effect tree by element id. The root cause of this crash is we are trying to animate a node that does not have element id set up in map yet. Before the bug was covered by operator[] used for access map, and that would ends up being a noop. R=wkorman BUG=706766, 707090, 702774 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== cc: Avoid Crash in Effect Tree Animation by Element ID Instead of crash, early out of function trying to animate on effect tree by element id. The root cause of this crash is we are trying to animate a node that does not have element id set up in map yet. Before the bug was covered by operator[] used for access map, and that would ends up being a noop. R=wkorman BUG=706766, 707090, 702774 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2794673002 Cr-Commit-Position: refs/heads/master@{#461432} Committed: https://chromium.googlesource.com/chromium/src/+/9975ad63f85f1fe76100602db988... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9975ad63f85f1fe76100602db988... |
