Re-land: Initial skeleton of Accessibility Object Model Phase 1

Re-land: Initial skeleton of Accessibility Object Model Phase 1

Landed: r460670   - https://codereview.chromium.org/2750533006/
Reverted: r461332 - https://codereview.chromium.org/2796553002

See the diff between patch set 1 and patch set 2 for the fix to the crash
that the initial patch caused.

Explainer: https://github.com/WICG/aom/blob/master/explainer.md
Spec: https://wicg.github.io/aom/spec/

This change adds an accessibleNode getter on Element, and implements
the role and label properties of AccessibleNode, including a LayoutTest
of the supported functionality.

Properties on an AccessibleNode are stored in a map for efficiency
since there are dozens of possible properties and few will need to be
set on any one particular object.

In existing accessibility code, places where we previously retrieve an
ARIA attribute are replaced with a new wrapper that first checks the
ARIA attribute and then checks the equivalent AOM property.

Once this change lands it should be relatively straightforward to implement
the rest of the properties of AccessibleNode and complete Phase 1.

BUG=680345, 707218
TBR=haraken,aboxhall,esprehn

Review-Url: https://codereview.chromium.org/2791943002
Cr-Commit-Position: refs/heads/master@{#461438}
Committed: https://chromium.googlesource.com/chromium/src/+/46fca1f2e467228e197bb0c792450ad54667bd5e

[dmazzoni, 2017-04-03 07:21:20]

Description was changed from

==========
Re-land: Initial skeleton of Accessibility Object Model Phase 1

Landed: r460670   - https://codereview.chromium.org/2750533006/
Reverted: r461332 - https://codereview.chromium.org/2796553002

BUG=680345,707218
TBR=haraken,aboxhall,esprehn
==========

to

==========
Re-land: Initial skeleton of Accessibility Object Model Phase 1

Landed: r460670   - https://codereview.chromium.org/2750533006/
Reverted: r461332 - https://codereview.chromium.org/2796553002

See the diff between patch set 1 and patch set 2 for the fix to the crash
that the initial patch caused.

Explainer: https://github.com/WICG/aom/blob/master/explainer.md
Spec: https://wicg.github.io/aom/spec/

This change adds an accessibleNode getter on Element, and implements
the role and label properties of AccessibleNode, including a LayoutTest
of the supported functionality.

Properties on an AccessibleNode are stored in a map for efficiency
since there are dozens of possible properties and few will need to be
set on any one particular object.

In existing accessibility code, places where we previously retrieve an
ARIA attribute are replaced with a new wrapper that first checks the
ARIA attribute and then checks the equivalent AOM property.

Once this change lands it should be relatively straightforward to implement
the rest of the properties of AccessibleNode and complete Phase 1.

BUG=680345,707218
TBR=haraken,aboxhall,esprehn
==========

[dmazzoni, 2017-04-03 07:24:26]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 07:24:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-04-03 07:25:16]

dmazzoni@chromium.org changed reviewers:
- haraken@chromium.org

[dmazzoni, 2017-04-03 07:25:16]

@aboxhall or @esprehn, please take a quick look at the difference
between patch set 1 and patch set 2 for the fix to the original
change.

[aboxhall, 2017-04-03 08:41:55]

lgtm

https://codereview.chromium.org/2791943002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2791943002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:2932: const
AtomicString& ariaLabel = AccessibleNode::getProperty(
This looks good, but why not do this everywhere getAOMPropertyOrARIAAttribute is
used?

[commit-bot: I haz the power, 2017-04-03 09:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 09:28:27]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-04-03 15:25:48]

Thanks

https://codereview.chromium.org/2791943002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2791943002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:2932: const
AtomicString& ariaLabel = AccessibleNode::getProperty(
On 2017/04/03 08:41:55, aboxhall wrote:
> This looks good, but why not do this everywhere getAOMPropertyOrARIAAttribute
is
> used?

It depends on whether we have an AXObject or an Elemenet.

If we have an AXObject, calling AccessibleNode::getProperty requires an extra
step
or two to get a node, make sure it's not null, and make sure it's an element.
But if we already have an element and not necessarily an AXObject for it,
we should call AccessibleNode::getProperty.

[dmazzoni, 2017-04-03 15:25:55]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-04-03 15:26:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 15:37:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491233155120330,
"parent_rev": "98750d7d38046584536d60a3a89a2863a8264ec7", "commit_rev":
"46fca1f2e467228e197bb0c792450ad54667bd5e"}

[commit-bot: I haz the power, 2017-04-03 15:37:52]

Description was changed from

==========
Re-land: Initial skeleton of Accessibility Object Model Phase 1

Landed: r460670   - https://codereview.chromium.org/2750533006/
Reverted: r461332 - https://codereview.chromium.org/2796553002

See the diff between patch set 1 and patch set 2 for the fix to the crash
that the initial patch caused.

Explainer: https://github.com/WICG/aom/blob/master/explainer.md
Spec: https://wicg.github.io/aom/spec/

This change adds an accessibleNode getter on Element, and implements
the role and label properties of AccessibleNode, including a LayoutTest
of the supported functionality.

Properties on an AccessibleNode are stored in a map for efficiency
since there are dozens of possible properties and few will need to be
set on any one particular object.

In existing accessibility code, places where we previously retrieve an
ARIA attribute are replaced with a new wrapper that first checks the
ARIA attribute and then checks the equivalent AOM property.

Once this change lands it should be relatively straightforward to implement
the rest of the properties of AccessibleNode and complete Phase 1.

BUG=680345,707218
TBR=haraken,aboxhall,esprehn
==========

to

==========
Re-land: Initial skeleton of Accessibility Object Model Phase 1

Landed: r460670   - https://codereview.chromium.org/2750533006/
Reverted: r461332 - https://codereview.chromium.org/2796553002

See the diff between patch set 1 and patch set 2 for the fix to the crash
that the initial patch caused.

Explainer: https://github.com/WICG/aom/blob/master/explainer.md
Spec: https://wicg.github.io/aom/spec/

This change adds an accessibleNode getter on Element, and implements
the role and label properties of AccessibleNode, including a LayoutTest
of the supported functionality.

Properties on an AccessibleNode are stored in a map for efficiency
since there are dozens of possible properties and few will need to be
set on any one particular object.

In existing accessibility code, places where we previously retrieve an
ARIA attribute are replaced with a new wrapper that first checks the
ARIA attribute and then checks the equivalent AOM property.

Once this change lands it should be relatively straightforward to implement
the rest of the properties of AccessibleNode and complete Phase 1.

BUG=680345,707218
TBR=haraken,aboxhall,esprehn

Review-Url: https://codereview.chromium.org/2791943002
Cr-Commit-Position: refs/heads/master@{#461438}
Committed:
https://chromium.googlesource.com/chromium/src/+/46fca1f2e467228e197bb0c79245...
==========

[commit-bot: I haz the power, 2017-04-03 15:37:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/46fca1f2e467228e197bb0c79245...