Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2796553002: Revert of Initial skeleton of Accessibility Object Model Phase 1 (Closed)

Created:
3 years, 8 months ago by Will Harris
Modified:
3 years, 8 months ago
CC:
aboxhall+watch_chromium.org, blink-reviews, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, kinuko+watch, nektar+watch_chromium.org, nektarios, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Initial skeleton of Accessibility Object Model Phase 1 (patchset #9 id:160001 of https://codereview.chromium.org/2750533006/ ) Reason for revert: major renderer on Canary see crbug.com/707218 Original issue's description: > Initial skeleton of Accessibility Object Model Phase 1 > > Explainer: https://github.com/WICG/aom/blob/master/explainer.md > Spec: https://wicg.github.io/aom/spec/ > > This change adds an accessibleNode getter on Element, and implements > the role and label properties of AccessibleNode, including a LayoutTest > of the supported functionality. > > Properties on an AccessibleNode are stored in a map for efficiency > since there are dozens of possible properties and few will need to be > set on any one particular object. > > In existing accessibility code, places where we previously retrieve an > ARIA attribute are replaced with a new wrapper that first checks the > ARIA attribute and then checks the equivalent AOM property. > > Once this change lands it should be relatively straightforward to implement > the rest of the properties of AccessibleNode and complete Phase 1. > > BUG=680345 > > Review-Url: https://codereview.chromium.org/2750533006 > Cr-Commit-Position: refs/heads/master@{#460670} > Committed: https://chromium.googlesource.com/chromium/src/+/59b48ec0a88a1716bd4b39b2ac2d3021458749f4 TBR=esprehn@chromium.org,aboxhall@chromium.org,haraken@chromium.org,dmazzoni@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=680345, 707218 Review-Url: https://codereview.chromium.org/2796553002 Cr-Commit-Position: refs/heads/master@{#461332} Committed: https://chromium.googlesource.com/chromium/src/+/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -443 lines) Patch
D third_party/WebKit/LayoutTests/accessibility/aom.html View 1 chunk +0 lines, -196 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/dom/AccessibleNode.h View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/Source/core/dom/AccessibleNode.cpp View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/WebKit/Source/core/dom/AccessibleNode.idl View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.h View 4 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.cpp View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 5 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 3 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Will Harris
Created Revert of Initial skeleton of Accessibility Object Model Phase 1
3 years, 8 months ago (2017-04-01 21:58:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796553002/1
3 years, 8 months ago (2017-04-01 21:58:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/71e44249f1bddfa5cfe90041b4b4cf497f39ecc0
3 years, 8 months ago (2017-04-01 23:33:23 UTC) #7
haraken
3 years, 8 months ago (2017-04-02 01:19:28 UTC) #8
Message was sent while issue was closed.
LGTM to revert

Powered by Google App Engine
This is Rietveld 408576698