Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 279193002: Fix GMOCK warnings in password_manager (Closed)

Created:
6 years, 7 months ago by Jiang Jiang
Modified:
6 years, 7 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix GMOCK warnings in password_manager In password_manager_unittests and password_form_manager_unittests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M components/password_manager/core/browser/password_form_manager_unittest.cc View 5 chunks +15 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_manager_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jiang Jiang
6 years, 7 months ago (2014-05-12 10:02:54 UTC) #1
Garrett Casto
lgtm
6 years, 7 months ago (2014-05-12 21:02:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/279193002/1
6 years, 7 months ago (2014-05-12 21:03:19 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 00:42:15 UTC) #4
Message was sent while issue was closed.
Change committed as 269939

Powered by Google App Engine
This is Rietveld 408576698