Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 279193002: Fix GMOCK warnings in password_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc
index 4a4244ba1876ac0d5c009cc82c5e638ed8d52e8f..a22aca4050df43027643fc9a0ba0449d412ac922 100644
--- a/components/password_manager/core/browser/password_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_manager_unittest.cc
@@ -71,6 +71,7 @@ class PasswordManagerTest : public testing::Test {
true);
store_ = new MockPasswordStore;
+ EXPECT_CALL(*store_, ReportMetrics()).Times(AnyNumber());
CHECK(store_->Init(syncer::SyncableService::StartSyncFlare()));
EXPECT_CALL(client_, GetPasswordStore()).WillRepeatedly(Return(store_));
@@ -91,8 +92,6 @@ class PasswordManagerTest : public testing::Test {
EXPECT_CALL(driver_, AllowPasswordGenerationForForm(_)).Times(AnyNumber());
EXPECT_CALL(driver_, GetPasswordAutofillManager())
.WillRepeatedly(Return(password_autofill_manager_.get()));
-
- EXPECT_CALL(*store_, ReportMetricsImpl()).Times(AnyNumber());
}
virtual void TearDown() {
« no previous file with comments | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698