Fix GMOCK warnings in password_manager

components/password_manager/core/browser/password_form_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/run_loop.h"
@@ skipping 362 matching lines @@
 TEST_F(PasswordFormManagerTest, TestAlternateUsername) {
   // Need a MessageLoop for callbacks.
   base::MessageLoop message_loop;
   scoped_refptr<TestPasswordStore> password_store = new TestPasswordStore;
   CHECK(password_store->Init(syncer::SyncableService::StartSyncFlare()));
 
   TestPasswordManagerClient client(password_store.get());
   TestPasswordManager password_manager(&client);
   scoped_ptr<PasswordFormManager> manager(new PasswordFormManager(
       &password_manager, &client, client.GetDriver(), *observed_form(), false));
+  EXPECT_CALL(*client.GetMockDriver(), AllowPasswordGenerationForForm(_))
+      .Times(1);
+  EXPECT_CALL(*client.GetMockDriver(), IsOffTheRecord())
+      .WillRepeatedly(Return(false));
 
   password_store->AddLogin(*saved_match());
   manager->FetchMatchingLoginsFromPasswordStore(PasswordStore::ALLOW_PROMPT);
   RunAllPendingTasks();
 
   // The saved match has the right username already.
   PasswordForm login(*observed_form());
   login.username_value = saved_match()->username_value;
   login.password_value = saved_match()->password_value;
   login.preferred = true;
@@ skipping 11 matching lines @@
   ASSERT_EQ(1U, passwords[saved_match()->signon_realm].size());
   EXPECT_EQ(saved_match()->username_value,
             passwords[saved_match()->signon_realm][0].username_value);
   EXPECT_EQ(0U,
             passwords[saved_match()->signon_realm][0]
                 .other_possible_usernames.size());
 
   // This time use an alternate username
   manager.reset(new PasswordFormManager(
       &password_manager, &client, client.GetDriver(), *observed_form(), false));
+  EXPECT_CALL(*client.GetMockDriver(), AllowPasswordGenerationForForm(_))
+      .Times(1);
   password_store->Clear();
   password_store->AddLogin(*saved_match());
   manager->FetchMatchingLoginsFromPasswordStore(PasswordStore::ALLOW_PROMPT);
   RunAllPendingTasks();
 
   base::string16 new_username = saved_match()->other_possible_usernames[0];
   login.username_value = new_username;
   manager->ProvisionallySave(
       login, PasswordFormManager::ALLOW_OTHER_POSSIBLE_USERNAMES);
 
@@ skipping 98 matching lines @@
   SimulateResponseFromPasswordStore(manager.get(), result);
   Mock::VerifyAndClearExpectations(client.GetMockDriver());
 
   // Sign up attempt to previously visited sites; Login result is found from
   // password store, and is not blacklisted; We should send the not blacklisted
   // message.
   manager.reset(new PasswordFormManager(
       &password_manager, &client, client.GetDriver(), *observed_form(), false));
   EXPECT_CALL(*client.GetMockDriver(), AllowPasswordGenerationForForm(_))
       .Times(1);
+  EXPECT_CALL(*client.GetMockDriver(), IsOffTheRecord())
+      .WillRepeatedly(Return(false));
   SimulateFetchMatchingLoginsFromPasswordStore(manager.get());
   // We need add heap allocated objects to result.
   result.push_back(CreateSavedMatch(false));
   SimulateResponseFromPasswordStore(manager.get(), result);
   Mock::VerifyAndClearExpectations(client.GetMockDriver());
 
   // Sign up attempt to previously visited sites; Login result is found from
   // password store, but is blacklisted; We should not send the not blacklisted
   // message.
   manager.reset(new PasswordFormManager(
       &password_manager, &client, client.GetDriver(), *observed_form(), false));
   EXPECT_CALL(*client.GetMockDriver(), AllowPasswordGenerationForForm(_))
       .Times(0);
   SimulateFetchMatchingLoginsFromPasswordStore(manager.get());
   result.clear();
   result.push_back(CreateSavedMatch(true));
   SimulateResponseFromPasswordStore(manager.get(), result);
   Mock::VerifyAndClearExpectations(client.GetMockDriver());
 }
 
 TEST_F(PasswordFormManagerTest, TestForceInclusionOfGeneratedPasswords) {
   base::MessageLoop message_loop;
 
   TestPasswordManagerClient client(NULL);
   TestPasswordManager password_manager(&client);
   scoped_ptr<PasswordFormManager> manager(new PasswordFormManager(
       &password_manager, &client, client.GetDriver(), *observed_form(), false));
+  EXPECT_CALL(*client.GetMockDriver(), AllowPasswordGenerationForForm(_))
+      .Times(1);
+  EXPECT_CALL(*client.GetMockDriver(), IsOffTheRecord())
+      .WillRepeatedly(Return(false));
 
   // Simulate having two matches for this origin, one of which was from a form
   // with different HTML tags for elements. Because of scoring differences,
   // only the first form will be sent to Autofill().
   std::vector<PasswordForm*> results;
   results.push_back(CreateSavedMatch(false));
   results.push_back(CreateSavedMatch(false));
   results[1]->username_value = ASCIIToUTF16("other@gmail.com");
   results[1]->password_element = ASCIIToUTF16("signup_password");
   results[1]->username_element = ASCIIToUTF16("signup_username");
   SimulateFetchMatchingLoginsFromPasswordStore(manager.get());
   SimulateResponseFromPasswordStore(manager.get(), results);
   EXPECT_EQ(1u, password_manager.GetLatestBestMatches().size());
   results.clear();
 
   // Same thing, except this time the credentials that don't match quite as
   // well are generated. They should now be sent to Autofill().
   manager.reset(new PasswordFormManager(
       &password_manager, &client, client.GetDriver(), *observed_form(), false));
+  EXPECT_CALL(*client.GetMockDriver(), AllowPasswordGenerationForForm(_))
+      .Times(1);
+
   results.push_back(CreateSavedMatch(false));
   results.push_back(CreateSavedMatch(false));
   results[1]->username_value = ASCIIToUTF16("other@gmail.com");
   results[1]->password_element = ASCIIToUTF16("signup_password");
   results[1]->username_element = ASCIIToUTF16("signup_username");
   results[1]->type = PasswordForm::TYPE_GENERATED;
   SimulateFetchMatchingLoginsFromPasswordStore(manager.get());
   SimulateResponseFromPasswordStore(manager.get(), results);
   EXPECT_EQ(2u, password_manager.GetLatestBestMatches().size());
 }
@@ skipping 123 matching lines @@
   results[1]->origin = GURL("http://accounts.google.com/a/ServiceLoginAuth2");
   results[1]->action = GURL("http://accounts.google.com/a/ServiceLogin2");
   SimulateFetchMatchingLoginsFromPasswordStore(manager.get());
   SimulateResponseFromPasswordStore(manager.get(), results);
   EXPECT_EQ(1u, password_manager.GetLatestBestMatches().size());
   EXPECT_EQ("", password_manager.GetLatestBestMatches().begin()
       ->second->original_signon_realm);
 }
 
 }  // namespace password_manager