Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2791663002: Revert of Enable VsyncAlignedInput to Field Trial (Closed)

Created:
3 years, 8 months ago by chongz
Modified:
3 years, 8 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable VsyncAlignedInput to Field Trial (patchset #1 id:40001 of https://codereview.chromium.org/2752363002/ ) Reason for revert: Reverting due to issue 704732. Will try to find the root cause before re-landing. Original issue's description: > Enable VsyncAlignedInput to field trial > > Enable Field Trial on Android, ChromeOS, Linux, Mac, Win. > > This patch will cause expected 1 frame delay in > "scheduler.tough_scheduling_cases.first_gesture_scroll_update_latency". > > Reasons for the delay: > The synthetic input controller sends |TouchMove| right before |BeginFrame|, which > means the ack will come back later and the generated |GestureScrollUpdate| will falls > into next |BeginFrame|. > > This is fine since the actual scroll result won't be rendered until next frame with or > without this patch. > > BUG=704134 > > Review-Url: https://codereview.chromium.org/2752363002 > Cr-Commit-Position: refs/heads/master@{#458921} > Committed: https://chromium.googlesource.com/chromium/src/+/5a7f45dab8372cb7b80ee24dfb137a7ced2049ea TBR=isherman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=704134 Review-Url: https://codereview.chromium.org/2791663002 Cr-Commit-Position: refs/heads/master@{#461202} Committed: https://chromium.googlesource.com/chromium/src/+/232fbc4bc87a4c35ea8ab60e1f7ff8e4e8e14de5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
chongz
Created Revert of Enable VsyncAlignedInput to Field Trial
3 years, 8 months ago (2017-03-31 18:52:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2791663002/1
3 years, 8 months ago (2017-03-31 18:52:53 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 20:15:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/232fbc4bc87a4c35ea8ab60e1f7f...

Powered by Google App Engine
This is Rietveld 408576698