Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2752363002: Enable VsyncAlignedInput to Field Trial (Closed)

Created:
3 years, 9 months ago by chongz
Modified:
3 years, 9 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable VsyncAlignedInput to field trial Enable Field Trial on Android, ChromeOS, Linux, Mac, Win. This patch will cause expected 1 frame delay in "scheduler.tough_scheduling_cases.first_gesture_scroll_update_latency". Reasons for the delay: The synthetic input controller sends |TouchMove| right before |BeginFrame|, which means the ack will come back later and the generated |GestureScrollUpdate| will falls into next |BeginFrame|. This is fine since the actual scroll result won't be rendered until next frame with or without this patch. BUG=704134 Review-Url: https://codereview.chromium.org/2752363002 Cr-Commit-Position: refs/heads/master@{#458921} Committed: https://chromium.googlesource.com/chromium/src/+/5a7f45dab8372cb7b80ee24dfb137a7ced2049ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
chongz
isherman@ PTAL, thanks!
3 years, 9 months ago (2017-03-22 17:55:47 UTC) #15
Ilya Sherman
lgtm
3 years, 9 months ago (2017-03-22 21:37:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752363002/40001
3 years, 9 months ago (2017-03-22 23:07:52 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:40001) as https://chromium.googlesource.com/chromium/src/+/5a7f45dab8372cb7b80ee24dfb137a7ced2049ea
3 years, 9 months ago (2017-03-22 23:14:08 UTC) #21
chongz
3 years, 8 months ago (2017-03-31 18:52:12 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.chromium.org/2791663002/ by chongz@chromium.org.

The reason for reverting is: Reverting due to issue 704732. Will try to find the
root cause before re-landing..

Powered by Google App Engine
This is Rietveld 408576698