|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by chongz Modified:
3 years, 9 months ago Reviewers:
Ilya Sherman CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable VsyncAlignedInput to field trial
Enable Field Trial on Android, ChromeOS, Linux, Mac, Win.
This patch will cause expected 1 frame delay in
"scheduler.tough_scheduling_cases.first_gesture_scroll_update_latency".
Reasons for the delay:
The synthetic input controller sends |TouchMove| right before |BeginFrame|, which
means the ack will come back later and the generated |GestureScrollUpdate| will falls
into next |BeginFrame|.
This is fine since the actual scroll result won't be rendered until next frame with or
without this patch.
BUG=704134
Review-Url: https://codereview.chromium.org/2752363002
Cr-Commit-Position: refs/heads/master@{#458921}
Committed: https://chromium.googlesource.com/chromium/src/+/5a7f45dab8372cb7b80ee24dfb137a7ced2049ea
Patch Set 1 #
Messages
Total messages: 22 (17 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Enable VsyncAlignedInput to field trial BUG= ========== to ========== Enable VsyncAlignedInput to field trial This patch will cause expected 1 frame delay in "scheduler.tough_scheduling_cases.first_gesture_scroll_update_latency". Reasons for the delay: The synthetic input controller sends |TouchMove| right before |BeginFrame|, which means the ack will come back later and the generated |GestureScrollUpdate| will falls into next |BeginFrame|. This is fine since the actual scroll result won't be rendered until next frame with or without this patch. BUG=704134 ==========
The CQ bit was checked by chongz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Enable VsyncAlignedInput to field trial This patch will cause expected 1 frame delay in "scheduler.tough_scheduling_cases.first_gesture_scroll_update_latency". Reasons for the delay: The synthetic input controller sends |TouchMove| right before |BeginFrame|, which means the ack will come back later and the generated |GestureScrollUpdate| will falls into next |BeginFrame|. This is fine since the actual scroll result won't be rendered until next frame with or without this patch. BUG=704134 ========== to ========== Enable VsyncAlignedInput to field trial Enable Field Trial on ChromeOS, Linux, Mac, Win. (No Android as we don't have simulation for Android unbuffered input) This patch will cause expected 1 frame delay in "scheduler.tough_scheduling_cases.first_gesture_scroll_update_latency". Reasons for the delay: The synthetic input controller sends |TouchMove| right before |BeginFrame|, which means the ack will come back later and the generated |GestureScrollUpdate| will falls into next |BeginFrame|. This is fine since the actual scroll result won't be rendered until next frame with or without this patch. BUG=704134 ==========
Description was changed from ========== Enable VsyncAlignedInput to field trial Enable Field Trial on ChromeOS, Linux, Mac, Win. (No Android as we don't have simulation for Android unbuffered input) This patch will cause expected 1 frame delay in "scheduler.tough_scheduling_cases.first_gesture_scroll_update_latency". Reasons for the delay: The synthetic input controller sends |TouchMove| right before |BeginFrame|, which means the ack will come back later and the generated |GestureScrollUpdate| will falls into next |BeginFrame|. This is fine since the actual scroll result won't be rendered until next frame with or without this patch. BUG=704134 ========== to ========== Enable VsyncAlignedInput to field trial Enable Field Trial on Android, ChromeOS, Linux, Mac, Win. This patch will cause expected 1 frame delay in "scheduler.tough_scheduling_cases.first_gesture_scroll_update_latency". Reasons for the delay: The synthetic input controller sends |TouchMove| right before |BeginFrame|, which means the ack will come back later and the generated |GestureScrollUpdate| will falls into next |BeginFrame|. This is fine since the actual scroll result won't be rendered until next frame with or without this patch. BUG=704134 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by chongz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:20001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
chongz@chromium.org changed reviewers: + isherman@chromium.org
isherman@ PTAL, thanks!
lgtm
The CQ bit was checked by chongz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490223987370520,
"parent_rev": "1139825719f0479bc40151d88e8bb416bafad5eb", "commit_rev":
"5a7f45dab8372cb7b80ee24dfb137a7ced2049ea"}
Message was sent while issue was closed.
Description was changed from ========== Enable VsyncAlignedInput to field trial Enable Field Trial on Android, ChromeOS, Linux, Mac, Win. This patch will cause expected 1 frame delay in "scheduler.tough_scheduling_cases.first_gesture_scroll_update_latency". Reasons for the delay: The synthetic input controller sends |TouchMove| right before |BeginFrame|, which means the ack will come back later and the generated |GestureScrollUpdate| will falls into next |BeginFrame|. This is fine since the actual scroll result won't be rendered until next frame with or without this patch. BUG=704134 ========== to ========== Enable VsyncAlignedInput to field trial Enable Field Trial on Android, ChromeOS, Linux, Mac, Win. This patch will cause expected 1 frame delay in "scheduler.tough_scheduling_cases.first_gesture_scroll_update_latency". Reasons for the delay: The synthetic input controller sends |TouchMove| right before |BeginFrame|, which means the ack will come back later and the generated |GestureScrollUpdate| will falls into next |BeginFrame|. This is fine since the actual scroll result won't be rendered until next frame with or without this patch. BUG=704134 Review-Url: https://codereview.chromium.org/2752363002 Cr-Commit-Position: refs/heads/master@{#458921} Committed: https://chromium.googlesource.com/chromium/src/+/5a7f45dab8372cb7b80ee24dfb13... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as https://chromium.googlesource.com/chromium/src/+/5a7f45dab8372cb7b80ee24dfb13...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in https://codereview.chromium.org/2791663002/ by chongz@chromium.org. The reason for reverting is: Reverting due to issue 704732. Will try to find the root cause before re-landing.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
