DownloadManager : Create transient downloads

DownloadManager : Create transient downloads

This CL enables callers to optionally set transient when starting a download.

BUG=700240
Review-Url: https://codereview.chromium.org/2791453003
Cr-Commit-Position: refs/heads/master@{#463040}
Committed: https://chromium.googlesource.com/chromium/src/+/c6564f4e73457259075fd14acd488970b156c281

[shaktisahu, 2017-03-31 00:36:42]

Description was changed from

==========
Passing boolean transient from DownloadManager

BUG=700240
==========

to

==========
Passing boolean transient from DownloadManager

BUG=700240
==========

[shaktisahu, 2017-03-31 00:36:43]

shaktisahu@chromium.org changed reviewers:
+ dtrainor@chromium.org

[shaktisahu, 2017-03-31 00:38:40]

shaktisahu@chromium.org changed reviewers:
+ qinmin@chromium.org

[shaktisahu, 2017-03-31 00:44:00]

Description was changed from

==========
Passing boolean transient from DownloadManager

BUG=700240
==========

to

==========
DownloadManager : Create transient downloads

This CL enables callers to optionally set transient when starting a download.

BUG=700240
==========

[shaktisahu, 2017-03-31 00:54:47]

PTAL

[shaktisahu, 2017-04-06 20:36:12]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 20:37:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2017-04-06 21:37:31]

lgtm thanks!  Can you validate that calling DownloadUrl() properly downloads
without showing any UI if this is set?

[commit-bot: I haz the power, 2017-04-06 21:47:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 21:47:16]

Dry run: This issue passed the CQ dry run.

[shaktisahu, 2017-04-06 22:12:29]

shaktisahu@chromium.org changed reviewers:
+ jam@chromium.org

[shaktisahu, 2017-04-06 22:12:30]

jam@ - PTAL at content/

[shaktisahu, 2017-04-07 19:22:45]

shaktisahu@chromium.org changed reviewers:
+ piman@chromium.org
- qinmin@chromium.org

[shaktisahu, 2017-04-07 19:25:49]

Looks like jam@ is not available.
piman@ - Can you please take a look at content/public/browser?
Should be straightforward.

[piman, 2017-04-07 20:27:58]

lgtm

https://codereview.chromium.org/2791453003/diff/20001/content/public/browser/...
File content/public/browser/download_url_parameters.h (right):

https://codereview.chromium.org/2791453003/diff/20001/content/public/browser/...
content/public/browser/download_url_parameters.h:207: void set_transient(bool
transient) { transient_ = transient; }
nit: can you add documentation for this new public API?

[shaktisahu, 2017-04-07 21:25:12]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:25:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 22:21:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:21:53]

Dry run: This issue passed the CQ dry run.

[shaktisahu, 2017-04-07 23:04:25]

The CQ bit was checked by shaktisahu@chromium.org

[shaktisahu, 2017-04-07 23:04:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2791453003/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2017-04-07 23:04:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 23:15:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491606265861240,
"parent_rev": "3f4f524dcb8700e6df122af9acc56ba86981d16c", "commit_rev":
"c6564f4e73457259075fd14acd488970b156c281"}

[commit-bot: I haz the power, 2017-04-07 23:16:20]

Description was changed from

==========
DownloadManager : Create transient downloads

This CL enables callers to optionally set transient when starting a download.

BUG=700240
==========

to

==========
DownloadManager : Create transient downloads

This CL enables callers to optionally set transient when starting a download.

BUG=700240

Review-Url: https://codereview.chromium.org/2791453003
Cr-Commit-Position: refs/heads/master@{#463040}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6564f4e73457259075fd14acd48...
==========

[commit-bot: I haz the power, 2017-04-07 23:16:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c6564f4e73457259075fd14acd48...