Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: content/browser/download/download_request_core.cc

Issue 2791453003: DownloadManager : Create transient downloads (Closed)
Patch Set: nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_request_core.h ('k') | content/public/browser/download_url_parameters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_request_core.cc
diff --git a/content/browser/download/download_request_core.cc b/content/browser/download/download_request_core.cc
index d454d0a9b0503b24c594eaaf3441df0450ddfa67..9415ae70f4598dcccb9cf0d30195179d1ed9bf8b 100644
--- a/content/browser/download/download_request_core.cc
+++ b/content/browser/download/download_request_core.cc
@@ -62,6 +62,7 @@ class DownloadRequestData : public base::SupportsUserData::Data {
return std::move(save_info_);
}
uint32_t download_id() const { return download_id_; }
+ bool is_transient() const { return transient_; }
const DownloadUrlParameters::OnStartedCallback& callback() const {
return on_started_callback_;
}
@@ -71,6 +72,7 @@ class DownloadRequestData : public base::SupportsUserData::Data {
std::unique_ptr<DownloadSaveInfo> save_info_;
uint32_t download_id_ = DownloadItem::kInvalidId;
+ bool transient_ = false;
DownloadUrlParameters::OnStartedCallback on_started_callback_;
};
@@ -85,6 +87,7 @@ void DownloadRequestData::Attach(net::URLRequest* request,
request_data->save_info_.reset(
new DownloadSaveInfo(parameters->GetSaveInfo()));
request_data->download_id_ = download_id;
+ request_data->transient_ = parameters->is_transient();
request_data->on_started_callback_ = parameters->callback();
request->SetUserData(&kKey, request_data);
}
@@ -199,6 +202,7 @@ DownloadRequestCore::DownloadRequestCore(net::URLRequest* request,
if (request_data) {
save_info_ = request_data->TakeSaveInfo();
download_id_ = request_data->download_id();
+ transient_ = request_data->is_transient();
on_started_callback_ = request_data->callback();
DownloadRequestData::Detach(request_);
is_partial_request_ = save_info_->offset > 0;
@@ -228,6 +232,7 @@ DownloadRequestCore::CreateDownloadCreateInfo(DownloadInterruptReason result) {
create_info->referrer_url = GURL(request()->referrer());
create_info->result = result;
create_info->download_id = download_id_;
+ create_info->transient = transient_;
create_info->offset = create_info->save_info->offset;
create_info->length = create_info->save_info->length;
return create_info;
« no previous file with comments | « content/browser/download/download_request_core.h ('k') | content/public/browser/download_url_parameters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698