Issue 2791353003: [Merge M58] Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages, and (2) z…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2791353003: [Merge M58] Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages, and (2) z… (Closed)

Created:
3 years, 8 months ago by please use gerrit instead

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

[Merge M58] Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages, and (2) zh-TW users and zh-CN pages. BUG=699370 Review-Url: https://codereview.chromium.org/2745253005 Cr-Commit-Position: refs/heads/master@{#457485} (cherry picked from commit 0611c94f01981658a9c0b6327d3195ad4a129d75) Review-Url: https://codereview.chromium.org/2791353003 . Cr-Commit-Position: refs/branch-heads/3029@{#567} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/593ccfbebcf847630f4ef126bee69afa2a7cf7ae

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -62 lines)			Patch
	M	components/translate/core/browser/translate_manager.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download
	M	components/translate/core/browser/translate_manager_unittest.cc	View		1 chunk	+0 lines, -58 lines	0 comments	Download

Total messages: 2 (1 generated)

please use gerrit instead

3 years, 8 months ago (2017-04-04 16:47:37 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
593ccfbebcf847630f4ef126bee69afa2a7cf7ae.