Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages, and (2) zh-TW users a…

Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages, and (2) zh-TW users and zh-CN pages.

BUG=699370
Review-Url: https://codereview.chromium.org/2745253005
Cr-Commit-Position: refs/heads/master@{#457485}
Committed: https://chromium.googlesource.com/chromium/src/+/0611c94f01981658a9c0b6327d3195ad4a129d75

[riesa, 2017-03-14 20:48:32]

The CQ bit was checked by riesa@chromium.org to run a CQ dry run

[riesa, 2017-03-14 20:48:52]

Description was changed from

==========
Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages,
and (2) zh-TW users and zh-CN pages.

BUG=684609
==========

to

==========
Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages,
and (2) zh-TW users and zh-CN pages.

BUG=684609
==========

[riesa, 2017-03-14 20:48:52]

riesa@chromium.org changed reviewers:
+ groby@chromium.org

[commit-bot: I haz the power, 2017-03-14 20:49:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[riesa, 2017-03-14 20:59:40]

This CL undoes changes that went into effect right before M57 went out when we
discovered not being able to detect zh-TW vs zh-CN was more of an issue that we
thought.

Now that the underlying issue is solved, we can trigger Translate again for
Chinese users visiting Chinese pages not localized to their home locale, e.g.
zh-TW users may want to convert zh-CN pages to zh-TW and can do this via
Translate.

[commit-bot: I haz the power, 2017-03-14 21:38:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 21:38:06]

Dry run: This issue passed the CQ dry run.

[riesa, 2017-03-15 22:58:56]

Description was changed from

==========
Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages,
and (2) zh-TW users and zh-CN pages.

BUG=684609
==========

to

==========
Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages,
and (2) zh-TW users and zh-CN pages.

BUG=699370
==========

[groby-ooo-7-16, 2017-03-15 22:58:58]

On 2017/03/14 20:59:40, riesa wrote:
> This CL undoes changes that went into effect right before M57 went out when we
> discovered not being able to detect zh-TW vs zh-CN was more of an issue that
we
> thought.
> 
> Now that the underlying issue is solved, we can trigger Translate again for
> Chinese users visiting Chinese pages not localized to their home locale, e.g.
> zh-TW users may want to convert zh-CN pages to zh-TW and can do this via
> Translate.

LGTM

[groby-ooo-7-16, 2017-03-15 22:59:17]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2017-03-15 23:00:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 00:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:43:42]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[riesa, 2017-03-16 17:14:12]

The CQ bit was checked by riesa@chromium.org

[commit-bot: I haz the power, 2017-03-16 17:14:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 17:53:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489684452424330, "parent_rev":
"7f238dd47bf022bc3f40fd64131c5a2784a9da3a", "commit_rev":
"0611c94f01981658a9c0b6327d3195ad4a129d75"}

[commit-bot: I haz the power, 2017-03-16 17:53:55]

Description was changed from

==========
Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages,
and (2) zh-TW users and zh-CN pages.

BUG=699370
==========

to

==========
Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages,
and (2) zh-TW users and zh-CN pages.

BUG=699370

Review-Url: https://codereview.chromium.org/2745253005
Cr-Commit-Position: refs/heads/master@{#457485}
Committed:
https://chromium.googlesource.com/chromium/src/+/0611c94f01981658a9c0b6327d31...
==========

[commit-bot: I haz the power, 2017-03-16 17:53:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0611c94f01981658a9c0b6327d31...