Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2791323002: Use framework style includes in ios/web_view/public. (Closed)

Created:
3 years, 8 months ago by michaeldo
Modified:
3 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use framework style includes in ios/web_view/public. BUG=704946 Review-Url: https://codereview.chromium.org/2791323002 Cr-Commit-Position: refs/heads/master@{#461494} Committed: https://chromium.googlesource.com/chromium/src/+/b48b353161948224246626099272017cb9fbbb4f

Patch Set 1 #

Total comments: 20

Patch Set 2 : Update includes spacing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -189 lines) Patch
M build/config/ios/rules.gni View 2 chunks +7 lines, -0 lines 0 comments Download
M ios/web_view/BUILD.gn View 4 chunks +60 lines, -17 lines 0 comments Download
D ios/web_view/internal/BUILD.gn View 1 chunk +0 lines, -71 lines 0 comments Download
D ios/web_view/internal/translate/BUILD.gn View 1 chunk +0 lines, -39 lines 0 comments Download
M ios/web_view/internal/translate/web_view_translate_accept_languages_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web_view/internal/web_view_url_request_context_getter.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web_view/internal/web_view_web_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web_view/internal/web_view_web_main_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web_view/internal/web_view_web_main_parts.h View 1 chunk +2 lines, -2 lines 0 comments Download
D ios/web_view/public/BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download
M ios/web_view/public/ChromeWebView.h View 1 chunk +6 lines, -3 lines 0 comments Download
M ios/web_view/public/cwv.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/public/cwv_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/public/cwv_html_element.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/public/cwv_navigation_action.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/public/cwv_navigation_delegate.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/public/cwv_translate_delegate.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/public/cwv_translate_manager.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/public/cwv_ui_delegate.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/public/cwv_user_content_controller.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/public/cwv_user_script.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/public/cwv_web_view.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/public/cwv_web_view_configuration.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/shell/shell_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/shell/translate_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M ios/web_view/shell/translate_controller.m View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
michaeldo
3 years, 8 months ago (2017-04-03 16:45:13 UTC) #2
sdefresne
lgtm with comments (if the bots are happy) https://codereview.chromium.org/2791323002/diff/1/ios/web_view/public/cwv_html_element.h File ios/web_view/public/cwv_html_element.h (right): https://codereview.chromium.org/2791323002/diff/1/ios/web_view/public/cwv_html_element.h#newcode9 ios/web_view/public/cwv_html_element.h:9: no ...
3 years, 8 months ago (2017-04-03 16:48:18 UTC) #3
michaeldo
https://codereview.chromium.org/2791323002/diff/1/ios/web_view/public/cwv_html_element.h File ios/web_view/public/cwv_html_element.h (right): https://codereview.chromium.org/2791323002/diff/1/ios/web_view/public/cwv_html_element.h#newcode9 ios/web_view/public/cwv_html_element.h:9: On 2017/04/03 16:48:17, sdefresne wrote: > no blank line ...
3 years, 8 months ago (2017-04-03 17:20:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2791323002/20001
3 years, 8 months ago (2017-04-03 17:21:14 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 18:57:35 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b48b353161948224246626099272...

Powered by Google App Engine
This is Rietveld 408576698