Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Unified Diff: ios/web_view/BUILD.gn

Issue 2791323002: Use framework style includes in ios/web_view/public. (Closed)
Patch Set: Update includes spacing. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/ios/rules.gni ('k') | ios/web_view/internal/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/BUILD.gn
diff --git a/ios/web_view/BUILD.gn b/ios/web_view/BUILD.gn
index 9b40bcee08389c3dc9cfaf088e161443e6bab17c..4b9ab1b687c667b98207d357056086454e9a2502 100644
--- a/ios/web_view/BUILD.gn
+++ b/ios/web_view/BUILD.gn
@@ -7,9 +7,12 @@ import("//build/config/ios/rules.gni")
import("//tools/grit/repack.gni")
config("config") {
- include_dirs = [
- "internal",
- "public",
+ defines = [ "CWV_IMPLEMENTATION" ]
+ libs = [
+ "CoreGraphics.framework",
+ "Foundation.framework",
+ "MobileCoreServices.framework",
+ "UIKit.framework",
]
}
@@ -17,11 +20,6 @@ ios_framework_bundle("web_view") {
output_name = "ChromeWebView"
info_plist = "Info.plist"
- sources = [
- "public/cwv.h",
- "public/cwv_export.h",
- ]
-
public_headers = [
"public/ChromeWebView.h",
"public/cwv.h",
@@ -39,10 +37,57 @@ ios_framework_bundle("web_view") {
"public/cwv_web_view_configuration.h",
]
+ public = [
+ "public/ChromeWebView.h",
+ ]
+
+ sources = [
+ "internal/cwv.mm",
+ "internal/cwv_html_element.mm",
+ "internal/cwv_html_element_internal.h",
+ "internal/cwv_navigation_action.mm",
+ "internal/cwv_navigation_action_internal.h",
+ "internal/cwv_user_content_controller.mm",
+ "internal/cwv_user_content_controller_internal.h",
+ "internal/cwv_user_script.mm",
+ "internal/cwv_web_view.mm",
+ "internal/cwv_web_view_configuration.mm",
+ "internal/cwv_web_view_configuration_internal.h",
+ "internal/pref_names.cc",
+ "internal/pref_names.h",
+ "internal/translate/cwv_translate_manager_impl.h",
+ "internal/translate/cwv_translate_manager_impl.mm",
+ "internal/translate/web_view_translate_accept_languages_factory.cc",
+ "internal/translate/web_view_translate_accept_languages_factory.h",
+ "internal/translate/web_view_translate_client.h",
+ "internal/translate/web_view_translate_client.mm",
+ "internal/web_view_browser_state.h",
+ "internal/web_view_browser_state.mm",
+ "internal/web_view_early_page_script_provider.h",
+ "internal/web_view_early_page_script_provider.mm",
+ "internal/web_view_java_script_dialog_presenter.h",
+ "internal/web_view_java_script_dialog_presenter.mm",
+ "internal/web_view_network_delegate.cc",
+ "internal/web_view_network_delegate.h",
+ "internal/web_view_url_request_context_getter.h",
+ "internal/web_view_url_request_context_getter.mm",
+ "internal/web_view_web_client.h",
+ "internal/web_view_web_client.mm",
+ "internal/web_view_web_main_delegate.h",
+ "internal/web_view_web_main_delegate.mm",
+ "internal/web_view_web_main_parts.h",
+ "internal/web_view_web_main_parts.mm",
+ "internal/web_view_web_state_policy_decider.h",
+ "internal/web_view_web_state_policy_decider.mm",
+ ]
+
+ sources += public_headers
+
deps = [
":packed_resources",
"//base",
"//components/infobars/core",
+ "//components/infobars/core",
"//components/keyed_service/core",
"//components/keyed_service/ios",
"//components/pref_registry",
@@ -51,25 +96,23 @@ ios_framework_bundle("web_view") {
"//components/translate/core/common",
"//components/translate/ios/browser",
"//ios/net",
+ "//ios/net",
"//ios/web",
+ "//ios/web:reload_type",
+ "//ios/web:user_agent",
"//ios/web:user_agent",
"//ios/web/public/app",
- "//ios/web_view/internal",
"//net",
"//net:extras",
"//ui/base",
"//url",
+ "//url",
]
- public_deps = [
- "//ios/web_view/public",
+ configs += [
+ "//build/config/compiler:enable_arc",
+ ":config",
]
-
- libs = [ "UIKit.framework" ]
-
- public_configs = [ ":config" ]
-
- configs += [ "//build/config/compiler:enable_arc" ]
}
repack("repack_resources") {
« no previous file with comments | « build/config/ios/rules.gni ('k') | ios/web_view/internal/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698