Split MirrorsData methods and MirrorsDataImpl data by element kind.

Split MirrorsData methods and MirrorsDataImpl data by element kind.

This is a step towards making MirrorsData(Impl) reusable for kernel
based elements.

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/5553b600e0aa032504a60ed3efa700112ca00971

[Johnni Winther, 2017-04-04 12:22:10]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-04-04 18:27:13]

lgtm but please address the change in ImmutableEmptySet

https://codereview.chromium.org/2791263005/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/mirrors_data.dart (right):

https://codereview.chromium.org/2791263005/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/mirrors_data.dart:260: if (mustRetainMetadata &&
isMemberReferencedFromMirrorSystem(element)) {
any reason you don't write this as a nested loop like: 

if (mustRetainMetadata) {
  hasRetainedMetadata = true;
    if (isMemberReferencedFromMirrorSystem(element)) {
      _retainMetadataOf(element);
      return true;
    }
}
return false;

https://codereview.chromium.org/2791263005/diff/1/pkg/compiler/lib/src/util/e...
File pkg/compiler/lib/src/util/emptyset.dart (right):

https://codereview.chromium.org/2791263005/diff/1/pkg/compiler/lib/src/util/e...
pkg/compiler/lib/src/util/emptyset.dart:21: E lookup(Object element) => null;
why this change? If you want Object everywhere, there are a few other places you
can replace E with Object like the return value on this line...

[Johnni Winther, 2017-04-05 06:59:59]

https://codereview.chromium.org/2791263005/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/mirrors_data.dart (right):

https://codereview.chromium.org/2791263005/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/mirrors_data.dart:260: if (mustRetainMetadata &&
isMemberReferencedFromMirrorSystem(element)) {
On 2017/04/04 18:27:13, Emily Fortuna wrote:
> any reason you don't write this as a nested loop like: 
> 
> if (mustRetainMetadata) {
>   hasRetainedMetadata = true;
>     if (isMemberReferencedFromMirrorSystem(element)) {
>       _retainMetadataOf(element);
>       return true;
>     }
> }
> return false;

No _good_ reason. Changed.

https://codereview.chromium.org/2791263005/diff/1/pkg/compiler/lib/src/util/e...
File pkg/compiler/lib/src/util/emptyset.dart (right):

https://codereview.chromium.org/2791263005/diff/1/pkg/compiler/lib/src/util/e...
pkg/compiler/lib/src/util/emptyset.dart:21: E lookup(Object element) => null;
On 2017/04/04 18:27:13, Emily Fortuna wrote:
> why this change? If you want Object everywhere, there are a few other places
you
> can replace E with Object like the return value on this line...

This class was made when `Iterable` used `E` in [lookup], [remove], [removeAll],
[retainAll], [contains] and [containsAll]. `Iterable` has since been changed to
use `Object`, this change just follows this.

[Johnni Winther, 2017-04-05 07:06:27]

Description was changed from

==========
Split MirrorsData methods and MirrorsDataImpl data by element kind.

This is a step towards making MirrorsData(Impl) reusable for kernel
based elements.
==========

to

==========
Split MirrorsData methods and MirrorsDataImpl data by element kind.

This is a step towards making MirrorsData(Impl) reusable for kernel
based elements.

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5553b600e0aa032504a60ed3efa700112ca00971
==========

[Johnni Winther, 2017-04-05 07:06:28]

Committed patchset #2 (id:20001) manually as
5553b600e0aa032504a60ed3efa700112ca00971 (presubmit successful).